mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jan Dittmer <j.dittmer@portrix.net>
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: i2c-via686a driver
Date: Sun, 23 Mar 2003 20:27:43 +0000	[thread overview]
Message-ID: <20030323202743.A11150@infradead.org> (raw)
In-Reply-To: <3E7E0B37.5060505@portrix.net>; from j.dittmer@portrix.net on Sun, Mar 23, 2003 at 08:29:59PM +0100

// The following register sets temp interrupt mode (bits 1-0 for temp1, 
// 3-2 for temp2, 5-4 for temp3).  Modes are:
//    00 interrupt stays as long as value is out-of-range
//    01 interrupt is cleared once register is read (default)
//    10 comparator mode- like 00, but ignores hysteresis
//    11 same as 00

	Please don't use C++-style comments in kernel code.

static inline u8 TEMP_TO_REG(long val)
{
	return (u8)
	    SENSORS_LIMIT(viaLUT[((val <= -500) ? 0 : (val >= 1100) ? 160 : 
				  ((val + 5) / 10 + 50))], 0, 255);
}

	Dead code?

static int via686a_id = 0;

	This doesn't need to be initialized.

      ERROR4:

	All-uppercase is ugly..
      

  reply	other threads:[~2003-03-23 20:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-23 19:29 Jan Dittmer
2003-03-23 20:27 ` Christoph Hellwig [this message]
2003-03-23 20:36   ` Dominik Kubla
2003-03-23 20:48     ` Christoph Hellwig
2003-03-23 21:33       ` Jan Dittmer
2003-03-23 21:41         ` Christoph Hellwig
2003-03-23 21:38       ` Jan Dittmer
2003-03-25  3:53         ` Greg KH
2003-03-25  3:54         ` Greg KH
2003-03-25  9:12           ` Jan Dittmer
2003-03-25 17:10             ` Greg KH
2003-03-24  1:35 ` loop's kernel_thread dave young
2003-03-23 21:52 i2c-via686a driver Adam J. Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030323202743.A11150@infradead.org \
    --to=hch@infradead.org \
    --cc=greg@kroah.com \
    --cc=j.dittmer@portrix.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®