mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jan Dittmer <j.dittmer@portrix.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: i2c-via686a driver
Date: Tue, 25 Mar 2003 09:10:32 -0800	[thread overview]
Message-ID: <20030325171032.GB15823@kroah.com> (raw)
In-Reply-To: <3E801D8B.2040107@portrix.net>

On Tue, Mar 25, 2003 at 10:12:43AM +0100, Jan Dittmer wrote:
> Greg KH wrote:
> >On Sun, Mar 23, 2003 at 10:38:43PM +0100, Jan Dittmer wrote:
> >
> >>Anyway, here is a corrected version.
> >
> >
> >Oops, one other thing.  The pci_device_id structure should be
> >initialized by using the .field = method, not the way the driver is
> >currently.
> >
> >Oh, and one patch that adds the Kconfig, Makefile, and driver to the
> >tree would be great.
> >
> I included that one with the first mail, but here it is again together 
> with the hopefully correctly fixed driver.

Yes, but you didn't include it all in one patch.  It's tough to apply a
.c file with 'patch' :)

Also, you need to set up the adapter.dev.parent pointer before calling
i2c_add_adapter().

Can you make that one change, and send a single patch?

thanks,

greg k-h

  reply	other threads:[~2003-03-25 17:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-23 19:29 Jan Dittmer
2003-03-23 20:27 ` Christoph Hellwig
2003-03-23 20:36   ` Dominik Kubla
2003-03-23 20:48     ` Christoph Hellwig
2003-03-23 21:33       ` Jan Dittmer
2003-03-23 21:41         ` Christoph Hellwig
2003-03-23 21:38       ` Jan Dittmer
2003-03-25  3:53         ` Greg KH
2003-03-25  3:54         ` Greg KH
2003-03-25  9:12           ` Jan Dittmer
2003-03-25 17:10             ` Greg KH [this message]
2003-03-24  1:35 ` loop's kernel_thread dave young
2003-03-23 21:52 i2c-via686a driver Adam J. Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030325171032.GB15823@kroah.com \
    --to=greg@kroah.com \
    --cc=j.dittmer@portrix.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®