* ide-scsi quirk.
@ 2003-03-24 16:41 davej
2003-03-24 17:30 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: davej @ 2003-03-24 16:41 UTC (permalink / raw)
To: alan; +Cc: linux-kernel
Alan,
as mentioned a few weeks back, something similar to
this went into 2.4 (I munged this one a bit).
It deals with the issue of DMA starting before the
drive is ready iirc.
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/scsi/ide-scsi.c linux-2.5/drivers/scsi/ide-scsi.c
--- bk-linus/drivers/scsi/ide-scsi.c 2003-02-04 12:58:09.000000000 +0000
+++ linux-2.5/drivers/scsi/ide-scsi.c 2003-03-17 23:42:33.000000000 +0000
@@ -78,6 +78,7 @@ typedef struct idescsi_pc_s {
#define PC_DMA_IN_PROGRESS 0 /* 1 while DMA in progress */
#define PC_WRITING 1 /* Data direction */
#define PC_TRANSFORM 2 /* transform SCSI commands */
+#define PC_DMA_OK 4 /* Use DMA */
/*
* SCSI command transformation layer
@@ -494,6 +495,10 @@ static ide_startstop_t idescsi_transfer_
ide_set_handler(drive, &idescsi_pc_intr, get_timeout(pc), NULL);
/* Send the actual packet */
atapi_output_bytes(drive, scsi->pc->c, 12);
+ if (test_bit (PC_DMA_OK, &pc->flags)) {
+ set_bit (PC_DMA_IN_PROGRESS, &pc->flags);
+ (void) (HWIF(drive)->ide_dma_begin(drive));
+ }
return ide_started;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ide-scsi quirk.
2003-03-24 16:41 ide-scsi quirk davej
@ 2003-03-24 17:30 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2003-03-24 17:30 UTC (permalink / raw)
To: davej; +Cc: alan, linux-kernel
> as mentioned a few weeks back, something similar to
> this went into 2.4 (I munged this one a bit).
>
> It deals with the issue of DMA starting before the
> drive is ready iirc.
Thats the least of the 2.5 ide-scsi problems, but yes its
probably one to add
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-03-24 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-24 16:41 ide-scsi quirk davej
2003-03-24 17:30 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®