[TRIVIAL PATCH][2.5.66] fix for link-error in i810fb_imageblit

[TRIVIAL PATCH][2.5.66] fix for link-error in i810fb_imageblit

[Andy Pfiffer]

This patch is one way to fix a link-error found in the i810 FB driver as
found in pure 2.5.66.

The error is reported as an undefined reference to __memcpy() inside
i810fb_imageblit().

The error:
        ld -m elf_i386  -T arch/i386/vmlinux.lds.s
arch/i386/kernel/head.o arch/i386/kernel/init_task.o   init/built-in.o
--start-group  usr/built-in.o  arch/i386/kernel/built-in.o 
arch/i386/mm/built-in.o  arch/i386/mach-default/built-in.o 
kernel/built-in.o  mm/built-in.o  fs/built-in.o  ipc/built-in.o 
security/built-in.o  crypto/built-in.o  lib/lib.a  arch/i386/lib/lib.a 
drivers/built-in.o  sound/built-in.o  arch/i386/pci/built-in.o 
net/built-in.o --end-group  -o .tmp_vmlinux1
drivers/built-in.o: In function `i810fb_imageblit':
drivers/built-in.o(.text+0xb59c1): undefined reference to `__memcpy'
make: *** [.tmp_vmlinux1] Error 1


The diff:

diff -Nru a/include/linux/fb.h b/include/linux/fb.h
--- a/include/linux/fb.h	Tue Mar 25 12:02:29 2003
+++ b/include/linux/fb.h	Tue Mar 25 12:02:29 2003
@@ -4,6 +4,7 @@
 #include <linux/tty.h>
 #include <asm/types.h>
 #include <asm/io.h>
+#include <asm/string.h>
 
 /* Definitions of frame buffers						*/
 

Re: [TRIVIAL PATCH][2.5.66] fix for link-error in i810fb_imageblit

[Russell King]

On Tue, Mar 25, 2003 at 12:13:19PM -0800, Andy Pfiffer wrote:
> The error:
>         ld -m elf_i386  -T arch/i386/vmlinux.lds.s
> arch/i386/kernel/head.o arch/i386/kernel/init_task.o   init/built-in.o
> --start-group  usr/built-in.o  arch/i386/kernel/built-in.o 
> arch/i386/mm/built-in.o  arch/i386/mach-default/built-in.o 
> kernel/built-in.o  mm/built-in.o  fs/built-in.o  ipc/built-in.o 
> security/built-in.o  crypto/built-in.o  lib/lib.a  arch/i386/lib/lib.a 
> drivers/built-in.o  sound/built-in.o  arch/i386/pci/built-in.o 
> net/built-in.o --end-group  -o .tmp_vmlinux1
> drivers/built-in.o: In function `i810fb_imageblit':
> drivers/built-in.o(.text+0xb59c1): undefined reference to `__memcpy'
> make: *** [.tmp_vmlinux1] Error 1
> 
> 
> The diff:
> 
> diff -Nru a/include/linux/fb.h b/include/linux/fb.h
> --- a/include/linux/fb.h	Tue Mar 25 12:02:29 2003
> +++ b/include/linux/fb.h	Tue Mar 25 12:02:29 2003
> @@ -4,6 +4,7 @@
>  #include <linux/tty.h>
>  #include <asm/types.h>
>  #include <asm/io.h>
> +#include <asm/string.h>
>  
>  /* Definitions of frame buffers						*/

Why linux/fb.h and why asm/string.h when we have linux/string.h?
Shouldn't <linux/string.h> be included by the i810fb driver?

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

Re: [TRIVIAL PATCH][2.5.66] fix for link-error in i810fb_imageblit

[James Simmons]

> Why linux/fb.h and why asm/string.h when we have linux/string.h?
> Shouldn't <linux/string.h> be included by the i810fb driver?

Done. I added linux/string.h to i810_accel.c.

Re: [TRIVIAL PATCH][2.5.66] fix for link-error in i810fb_imageblit

[Andy Pfiffer]

On Tue, 2003-03-25 at 12:49, James Simmons wrote:
> > Why linux/fb.h and why asm/string.h when we have linux/string.h?
> > Shouldn't <linux/string.h> be included by the i810fb driver?
> 
> Done. I added linux/string.h to i810_accel.c.

Thanks.  Works for me. ;^)