* [PATCH 2.5] fix OSS cs4232 linking when compiled-in
@ 2003-03-25 22:11 Daniel Ritz
2003-03-26 20:26 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Ritz @ 2003-03-25 22:11 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel, bwindle-kbt
hi
this patch fixes the linking of sound/oss/cs4232.c.
unload_cs4232 can't be __exit since it's called from cs_4232_pnp_remove
which isn't __exit.
against 2.5.66-bk. please apply.
[fixes bugzilla.kernel.org #499]
rgds
-daniel
===== sound/oss/cs4232.c 1.10 vs edited =====
--- 1.10/sound/oss/cs4232.c Wed Feb 26 11:52:04 2003
+++ edited/sound/oss/cs4232.c Tue Mar 25 22:55:07 2003
@@ -313,7 +313,7 @@
}
}
-static void __exit unload_cs4232(struct address_info *hw_config)
+static void unload_cs4232(struct address_info *hw_config)
{
int base = hw_config->io_base, irq = hw_config->irq;
int dma1 = hw_config->dma, dma2 = hw_config->dma2;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.5] fix OSS cs4232 linking when compiled-in
2003-03-25 22:11 [PATCH 2.5] fix OSS cs4232 linking when compiled-in Daniel Ritz
@ 2003-03-26 20:26 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2003-03-26 20:26 UTC (permalink / raw)
To: Daniel Ritz; +Cc: Linus Torvalds, Linux Kernel Mailing List, bwindle-kbt
On Tue, 2003-03-25 at 22:11, Daniel Ritz wrote:
> hi
>
> this patch fixes the linking of sound/oss/cs4232.c.
> unload_cs4232 can't be __exit since it's called from cs_4232_pnp_remove
> which isn't __exit.
Correct - but surely it shoudl be __devexit ?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-03-26 19:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-25 22:11 [PATCH 2.5] fix OSS cs4232 linking when compiled-in Daniel Ritz
2003-03-26 20:26 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®