* [patch] fix atm/iphase.c .text.exit error
@ 2003-03-27 22:14 Adrian Bunk
2003-03-31 20:05 ` chas williams
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2003-03-27 22:14 UTC (permalink / raw)
To: chas, Marcelo Tosatti, Linus Torvalds; +Cc: linux-kernel
The function ia_remove_one in drivers/atm/iphase.c is __devexit but the
pointer to it doesn't use __devexit_p resulting in a .text.exit error if
!CONFIG_HOTPLUG.
The following patch is needed:
--- linux-2.4.21-pre6-full-nohotplug/drivers/atm/iphase.c.old 2003-03-27 22:45:31.000000000 +0100
+++ linux-2.4.21-pre6-full-nohotplug/drivers/atm/iphase.c 2003-03-27 22:46:28.000000000 +0100
@@ -3322,7 +3322,7 @@
.name = DEV_LABEL,
.id_table = ia_pci_tbl,
.probe = ia_init_one,
- .remove = ia_remove_one,
+ .remove = __devexit_p(ia_remove_one),
};
static int __init ia_init_module(void)
This patch applies against 2.4.21-pre6 and 2.5.66. I've tested the
compilation with 2.4.21-pre6.
Please apply
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] fix atm/iphase.c .text.exit error
2003-03-27 22:14 [patch] fix atm/iphase.c .text.exit error Adrian Bunk
@ 2003-03-31 20:05 ` chas williams
2003-03-31 21:36 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: chas williams @ 2003-03-31 20:05 UTC (permalink / raw)
To: davem; +Cc: Marcelo Tosatti, linux-kernel, Adrian Bunk
please apply this to 2.4 and 2.5. thanks in advance.
In message <20030327221431.GG24744@fs.tum.de>,Adrian Bunk writes:
>The function ia_remove_one in drivers/atm/iphase.c is __devexit but the
>pointer to it doesn't use __devexit_p resulting in a .text.exit error if
>!CONFIG_HOTPLUG.
>
>The following patch is needed:
>
>
>--- linux-2.4.21-pre6-full-nohotplug/drivers/atm/iphase.c.old 2003-03-27 22:4
>5:31.000000000 +0100
>+++ linux-2.4.21-pre6-full-nohotplug/drivers/atm/iphase.c 2003-03-27 22:4
>6:28.000000000 +0100
>@@ -3322,7 +3322,7 @@
> .name = DEV_LABEL,
> .id_table = ia_pci_tbl,
> .probe = ia_init_one,
>- .remove = ia_remove_one,
>+ .remove = __devexit_p(ia_remove_one),
> };
>
> static int __init ia_init_module(void)
>
>
>This patch applies against 2.4.21-pre6 and 2.5.66. I've tested the
>compilation with 2.4.21-pre6.
>
>Please apply
>Adrian
>
>--
>
> "Is there not promise of rain?" Ling Tan asked suddenly out
> of the darkness. There had been need of rain for many days.
> "Only a promise," Lao Er said.
> Pearl S. Buck - Dragon Seed
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-03-31 21:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-27 22:14 [patch] fix atm/iphase.c .text.exit error Adrian Bunk
2003-03-31 20:05 ` chas williams
2003-03-31 21:36 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®