* 2.5.66-mm3: drivers/atm/iphase.c doesn't compile
2003-04-03 8:58 2.5.66-mm3 Andrew Morton
@ 2003-04-03 12:14 ` Adrian Bunk
2003-04-03 12:24 ` chas williams
2003-04-03 12:45 ` 2.5.66-mm3 Erik Hensema
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Adrian Bunk @ 2003-04-03 12:14 UTC (permalink / raw)
To: Andrew Morton, chas; +Cc: linux-kernel
On Thu, Apr 03, 2003 at 12:58:17AM -0800, Andrew Morton wrote:
>...
> All 112 patches:
>
>
> linus.patch
>...
It seems the following compile error comes from Linus' tree:
<-- snip -->
...
gcc -Wp,-MD,drivers/atm/.iphase.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-pipe -mpreferred-stack-boundary=2 -march=k6
-Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include -g
-DKBUILD_BASENAME=iphase -DKBUILD_MODNAME=iphase -c -o
drivers/atm/iphase.o drivers/atm/iphase.c
drivers/atm/iphase.c: In function `ia_pkt_tx':
drivers/atm/iphase.c:2979: `pad' undeclared (first use in this function)
drivers/atm/iphase.c:2979: (Each undeclared identifier is reported only once
drivers/atm/iphase.c:2979: for each function it appears in.)
make[2]: *** [drivers/atm/iphase.o] Error 1
<-- snip -->
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: 2.5.66-mm3: drivers/atm/iphase.c doesn't compile
2003-04-03 12:14 ` 2.5.66-mm3: drivers/atm/iphase.c doesn't compile Adrian Bunk
@ 2003-04-03 12:24 ` chas williams
2003-04-03 12:34 ` David S. Miller
0 siblings, 1 reply; 7+ messages in thread
From: chas williams @ 2003-04-03 12:24 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel, davem
In message <20030403121422.GJ3693@fs.tum.de>,Adrian Bunk writes:
>drivers/atm/iphase.c:2979: `pad' undeclared (first use in this function)
>drivers/atm/iphase.c:2979: (Each undeclared identifier is reported only once
>drivers/atm/iphase.c:2979: for each function it appears in.)
i missed this one since i normally dont compile the iphase with debugging.
apply the following please to the 2.4 and 2.5 tree:
Index: linux/drivers/atm/iphase.c
===================================================================
RCS file: /home/chas/CVSROOT/linux/drivers/atm/iphase.c,v
retrieving revision 1.2
diff -u -r1.2 iphase.c
--- linux/drivers/atm/iphase.c 26 Mar 2003 17:28:02 -0000 1.2
+++ linux/drivers/atm/iphase.c 3 Apr 2003 12:20:15 -0000
@@ -2976,7 +2970,7 @@
make it aligned on a 48 byte boundary. */
total_len = skb->len + sizeof(struct cpcs_trailer);
total_len = ((total_len + 47) / 48) * 48;
- IF_TX(printk("ia packet len:%d padding:%d\n", total_len, pad);)
+ IF_TX(printk("ia packet len:%d padding:%d\n", total_len, total_len - skb->len);)
/* Put the packet in a tx buffer */
trailer = iadev->tx_buf[desc-1].cpcs;
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: 2.5.66-mm3: drivers/atm/iphase.c doesn't compile
2003-04-03 12:24 ` chas williams
@ 2003-04-03 12:34 ` David S. Miller
0 siblings, 0 replies; 7+ messages in thread
From: David S. Miller @ 2003-04-03 12:34 UTC (permalink / raw)
To: chas; +Cc: bunk, akpm, linux-kernel
From: chas williams <chas@locutus.cmf.nrl.navy.mil>
Date: Thu, 03 Apr 2003 07:24:03 -0500
In message <20030403121422.GJ3693@fs.tum.de>,Adrian Bunk writes:
>drivers/atm/iphase.c:2979: `pad' undeclared (first use in this function)
>drivers/atm/iphase.c:2979: (Each undeclared identifier is reported only once
>drivers/atm/iphase.c:2979: for each function it appears in.)
i missed this one since i normally dont compile the iphase with debugging.
apply the following please to the 2.4 and 2.5 tree:
Applied, thanks Chas.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 2.5.66-mm3
2003-04-03 8:58 2.5.66-mm3 Andrew Morton
2003-04-03 12:14 ` 2.5.66-mm3: drivers/atm/iphase.c doesn't compile Adrian Bunk
@ 2003-04-03 12:45 ` Erik Hensema
2003-04-03 20:02 ` 2.5.66-mm3: acpiphp_glue.c must depend on CONFIG_ACPI_BUS Adrian Bunk
2003-06-01 12:06 ` 2.5.66-mm3 and raid still oopses, but later than mm1/mm2 Helge Hafting
3 siblings, 0 replies; 7+ messages in thread
From: Erik Hensema @ 2003-04-03 12:45 UTC (permalink / raw)
To: linux-kernel
Andrew Morton (akpm@digeo.com) wrote:
> . The CPU scheduler starvation fix which was supposed to be in 2.5.66-mm2
> actually wasn't included. This time it's here for real.
This seems to have solved the problem for me that when I closed my
mutt-in-rxvt, the window wasn't removed from the screen for several seconds
[1], while mutt had clearly quit. Stangely enough, I only noticed this
effect when running rxvt, and only when closing the app running in it.
Anyway, when I press 'q' in mutt now, the window closes instantly, so I'm
happy ;-)
[1] on an Athlon XP 1800+ with Matrox G550
--
Erik Hensema <erik@hensema.net>
^ permalink raw reply [flat|nested] 7+ messages in thread
* 2.5.66-mm3: acpiphp_glue.c must depend on CONFIG_ACPI_BUS
2003-04-03 8:58 2.5.66-mm3 Andrew Morton
2003-04-03 12:14 ` 2.5.66-mm3: drivers/atm/iphase.c doesn't compile Adrian Bunk
2003-04-03 12:45 ` 2.5.66-mm3 Erik Hensema
@ 2003-04-03 20:02 ` Adrian Bunk
2003-06-01 12:06 ` 2.5.66-mm3 and raid still oopses, but later than mm1/mm2 Helge Hafting
3 siblings, 0 replies; 7+ messages in thread
From: Adrian Bunk @ 2003-04-03 20:02 UTC (permalink / raw)
To: Andrew Morton, t-kouchi; +Cc: linux-kernel, greg
This is most likely neither new nor specific to -mm:
It seems drivers/hotplug/acpiphp_glue.c depends on CONFIG_ACPI_BUS
and/or similar options but this isn't expressed in the Kconfig file
(this compile error occurs with CONFIG_ACPI_HT_ONLY enabled):
<-- snip -->
...
gcc -Wp,-MD,drivers/hotplug/.acpiphp_glue.o.d -D__KERNEL__ -Iinclude
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-pipe -mpreferred-stack-boundary=2 -march=k6 -Iinclude/asm-i386/mach-default
-nostdinc -iwithprefix include -D_LINUX
-I/home/bunk/linux/kernel-2.5/linux-2.5.66-mm3/drivers/acpi -DKBUILD_BASENAME=acpiphp_glue -DKBUILD_MODNAME=acpiphp -c -o
drivers/hotplug/acpiphp_glue.o drivers/hotplug/acpiphp_glue.c
drivers/hotplug/acpiphp_glue.c:642: warning: `struct acpi_device'
declared inside parameter list
drivers/hotplug/acpiphp_glue.c:642: warning: its scope is only this
definition or declaration, which is probably not what you want
drivers/hotplug/acpiphp_glue.c: In function `add_bridges':
drivers/hotplug/acpiphp_glue.c:644: dereferencing pointer to incomplete type
drivers/hotplug/acpiphp_glue.c: In function `enable_device':
drivers/hotplug/acpiphp_glue.c:828: warning: assignment makes pointer
from integer without a cast
drivers/hotplug/acpiphp_glue.c: At top level:
drivers/hotplug/acpiphp_glue.c:1050: variable `acpi_pci_hp_driver' has
initializer but incomplete type
drivers/hotplug/acpiphp_glue.c:1051: unknown field `name' specified in
initializer
drivers/hotplug/acpiphp_glue.c:1051: warning: excess elements in struct
initializer
drivers/hotplug/acpiphp_glue.c:1051: warning: (near initialization for
`acpi_pci_hp_driver')
drivers/hotplug/acpiphp_glue.c:1052: unknown field `class' specified in
initializer
drivers/hotplug/acpiphp_glue.c:1052: warning: excess elements in struct
initializer
drivers/hotplug/acpiphp_glue.c:1052: warning: (near initialization for
`acpi_pci_hp_driver')
drivers/hotplug/acpiphp_glue.c:1053: unknown field `ids' specified in
initializer
drivers/hotplug/acpiphp_glue.c:1053: warning: excess elements in struct
initializer
drivers/hotplug/acpiphp_glue.c:1053: warning: (near initialization for
`acpi_pci_hp_driver')
drivers/hotplug/acpiphp_glue.c:1054: unknown field `ops' specified in
initializer
drivers/hotplug/acpiphp_glue.c:1054: extra brace group at end of
initializer
drivers/hotplug/acpiphp_glue.c:1054: (near initialization for
`acpi_pci_hp_driver')
drivers/hotplug/acpiphp_glue.c:1056: warning: excess elements in struct
initializer
drivers/hotplug/acpiphp_glue.c:1056: warning: (near initialization for
`acpi_pci_hp_driver')
drivers/hotplug/acpiphp_glue.c: In function `acpiphp_glue_init':
drivers/hotplug/acpiphp_glue.c:1070: warning: implicit declaration of
function `acpi_bus_register_driver'
include/linux/ctype.h: At top level:
drivers/hotplug/acpiphp_glue.c:1050: storage size of
`acpi_pci_hp_driver' isn't known
make[2]: *** [drivers/hotplug/acpiphp_glue.o] Error 1
<-- snip -->
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: 2.5.66-mm3 and raid still oopses, but later than mm1/mm2
2003-04-03 8:58 2.5.66-mm3 Andrew Morton
` (2 preceding siblings ...)
2003-04-03 20:02 ` 2.5.66-mm3: acpiphp_glue.c must depend on CONFIG_ACPI_BUS Adrian Bunk
@ 2003-06-01 12:06 ` Helge Hafting
3 siblings, 0 replies; 7+ messages in thread
From: Helge Hafting @ 2003-06-01 12:06 UTC (permalink / raw)
To: Andrew Morton, neilb; +Cc: linux-kernel, linux-mm
2.5.70-mm3 with raid1 has improved to some extent,
the RAID crash now happens somewhat later.
I got a lot of kernel errors during RAID initialization,
with normal boot messages inbetween. Nothing made it to
the logs. I eventually got this:
Kernel BUG at mm/slab.c:1682
invalid operand 0000 [#1]
PREEMPTSMP
CPU:0
EIP at free_block+0x276/0x350
process fsck
Call trace:
drain_array
reap_timer_fnc
reap_timer_fnc
run_timer_softirq
do_softirq
smp_apic_timer
apic_timer_interrupt
<0> KErnel panic exception in interrupt
in interrupt - not syncing
reboot in 300 seconds
This is 2.5.70-mm3, with a patch that makes
matroxfb work so I could see the entire oops.
This is a dual celeron, with 2 scsi disks.
Root & /home is on raid-1, there is also a raid-0,
all disk-based filesystems are ext2.
Helge Hafting
^ permalink raw reply [flat|nested] 7+ messages in thread