From: Chuck Ebbert <76306.1226@compuserve.com>
To: Robert Love <rml@tech9.net>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] New cpu macro and i386 cleanup
Date: Sat, 5 Apr 2003 05:24:39 -0500 [thread overview]
Message-ID: <200304050525_MC3-1-331B-F7E3@compuserve.com> (raw)
Robert Love wrote:
> I like, although I am not hot on the name, but that is just taste.
I found myself wishing for C++ just for the function overloading so
it could be 'is_current(cpu)' or similar.
> One minor nit: it is not preempt-safe.
I was wondering whether the code I converted was running with preempt
disabled or not but didn't check. (The very thought of preempt on
SMP scares me anyway, so I avoid it.)
smp_processor_id() is not preempt-safe either, since the id could
change before you even get a chance to use the value. How many
thousands of lines of code remain that were written assuming things
would not change underneath them in kernel mode?
> Maybe put a comment above it like:
How about one for the whole kernel?
/**********
* WARNING: Use preempt at your own risk.
**********/
--
Chuck
I am not a number!
next reply other threads:[~2003-04-05 10:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-05 10:24 Chuck Ebbert [this message]
2003-04-05 18:56 ` Robert Love
-- strict thread matches above, loose matches on Subject: below --
2003-04-05 22:17 Chuck Ebbert
2003-04-05 0:29 Chuck Ebbert
2003-04-05 1:05 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200304050525_MC3-1-331B-F7E3@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®