From: Rusty Russell <rusty@rustcorp.com.au>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: zwane@linuxpower.ca, linux-kernel@vger.kernel.org, hch@infradead.org
Subject: Re: SET_MODULE_OWNER?
Date: Tue, 08 Apr 2003 12:01:37 +1000 [thread overview]
Message-ID: <20030408021239.1155C2C4EE@lists.samba.org> (raw)
In-Reply-To: Your message of "Mon, 07 Apr 2003 14:29:44 -0400." <3E91C398.9070400@pobox.com>
In message <3E91C398.9070400@pobox.com> you write:
> Rusty Russell wrote:
> > I thought it was completely useless, hence deprecated.
> >
> > Anyone have any reason to defend it?
>
>
> It's used to allow source compatibility with all kernels, old or new.
>
> Thus it is in active use, and should not be removed.
Inside individual drivers, or a set of compat macros, it makes sense.
But as a general module.h primitive it doesn't.
Imagine a structure adds an owner field in 2.5. This macro doesn't
help you, you need a specific compat macro for that struct.
ie. AFAICT it only buys you 2.2 compatibility, and even then only if
you #define it at the top of your driver.
I still don't understand: please demonstrate a use in existing source.
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2003-04-08 2:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-07 6:47 SET_MODULE_OWNER? Rusty Russell
2003-04-07 8:17 ` SET_MODULE_OWNER? Christoph Hellwig
2003-04-07 18:29 ` SET_MODULE_OWNER? Jeff Garzik
2003-04-08 2:01 ` Rusty Russell [this message]
2003-04-08 2:16 ` SET_MODULE_OWNER? Zwane Mwaikambo
2003-04-08 3:41 ` SET_MODULE_OWNER? Rusty Russell
2003-04-08 4:39 ` SET_MODULE_OWNER? Jeff Garzik
2003-04-09 0:46 ` SET_MODULE_OWNER? Rusty Russell
2003-04-09 2:32 ` SET_MODULE_OWNER? Jeff Garzik
2003-04-08 2:27 ` SET_MODULE_OWNER? Jeff Garzik
2003-04-08 3:46 ` SET_MODULE_OWNER? Rusty Russell
2003-04-08 6:00 ` SET_MODULE_OWNER? Christoph Hellwig
2003-04-08 11:51 ` SET_MODULE_OWNER? Alan Cox
2003-04-08 14:46 ` SET_MODULE_OWNER? Jamie Lokier
2003-04-08 15:12 ` SET_MODULE_OWNER? Jeff Garzik
2003-04-08 16:45 ` SET_MODULE_OWNER? Jamie Lokier
2003-04-08 17:19 ` SET_MODULE_OWNER? Jeff Garzik
[not found] <3E92515B.6030807@pobox.com>
2003-04-08 12:25 ` SET_MODULE_OWNER? Rusty Russell
2003-04-09 0:13 ` SET_MODULE_OWNER? David S. Miller
2003-04-09 1:03 ` SET_MODULE_OWNER? Jeff Garzik
2003-04-09 3:23 ` SET_MODULE_OWNER? Rusty Russell
2003-04-09 3:48 ` SET_MODULE_OWNER? Jeff Garzik
2003-04-09 15:00 ` SET_MODULE_OWNER? Kai Germaschewski
[not found] <3E93AA3D.4050104@pobox.com>
2003-04-09 5:27 ` SET_MODULE_OWNER? Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030408021239.1155C2C4EE@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®