mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Roland Dreier <roland@topspin.com>
Cc: spstarr@sh0n.net, rml@tech9.net, rmk@arm.linux.org.uk,
	linux-kernel@vger.kernel.org
Subject: Re: [BUG][2.5.66bk9+] - tty hangings - patches, dmesg & sysctl+T info
Date: Tue, 8 Apr 2003 21:27:49 -0700	[thread overview]
Message-ID: <20030408212749.56a8737c.akpm@digeo.com> (raw)
In-Reply-To: <524r58nw4e.fsf@topspin.com>

Roland Dreier <roland@topspin.com> wrote:
>
> Andrew, I've never seen a reply from you about this, can you tell me
> if I'm missing something here?
> 

No, I agree.  I don't think pending delayed work should contribute to the
count at all.

If someone wants to synchronise with the workqueue system they should cancel
any delayed work which they own (via cancel_scheduled_work) and then wait on
any currently-queued works via flush_scheduled_work().

So flush_scheduled_work() only needs to care about currently-queued works,
not the ones which are pending a timer event.

And flush_scheduled_work() needs to be taught to not lock up if someone keeps
re-adding work.

That's what my patch did (I think; it was a quicky)



  reply	other threads:[~2003-04-09  4:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-06 20:09 [BUG][2.5.66bk9+] - changes to timers still broken - we don't oops anymore Shawn Starr
2003-04-06 20:20 ` Roland Dreier
2003-04-06 20:38 ` Andrew Morton
2003-04-06 21:00   ` Shawn Starr
2003-04-09  2:12   ` [BUG][2.5.66bk9+] - tty hangings - patches, dmesg & sysctl+T info Shawn Starr
2003-04-09  4:12     ` Andrew Morton
2003-04-09  4:47       ` Roland Dreier
2003-04-09  4:56         ` Andrew Morton
2003-04-09  4:16     ` Roland Dreier
2003-04-09  4:27       ` Andrew Morton [this message]
2003-04-09  4:52         ` Roland Dreier
2003-04-09  5:01           ` Shawn Starr
2003-04-12 16:08 Shawn Starr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030408212749.56a8737c.akpm@digeo.com \
    --to=akpm@digeo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=rml@tech9.net \
    --cc=roland@topspin.com \
    --cc=spstarr@sh0n.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®