Re: [PATCH] compatmac is not needed

Re: [PATCH] compatmac is not needed

[David Woodhouse]

On Tue, 2003-04-08 at 17:42, Linux Kernel Mailing List wrote:
> ChangeSet 1.1089, 2003/04/08 09:42:06-07:00, alan@lxorguk.ukuu.org.uk
> 
> 	[PATCH] compatmac is not needed

Er, compatmac is there to make new code work in older kernels. The only
concession we have to make for compatibility in the actual code is that
#include, and we put all the ugliness into compatmac.h which makes it
work in older kernels. 

So compatmac.h ends up _empty_ in the latest kernel, but that doesn't
mean it's not needed.

Please don't break stuff just for the sake of it.

-- 
dwmw2

Re: [PATCH] compatmac is not needed

[Ingo Oeser]

On Wed, Apr 09, 2003 at 09:39:15AM +0100, David Woodhouse wrote:
> On Tue, 2003-04-08 at 17:42, Linux Kernel Mailing List wrote:
> > ChangeSet 1.1089, 2003/04/08 09:42:06-07:00, alan@lxorguk.ukuu.org.uk
> > 
> > 	[PATCH] compatmac is not needed
> 
> So compatmac.h ends up _empty_ in the latest kernel, but that doesn't
> mean it's not needed.
> 
> Please don't break stuff just for the sake of it.

So this is still a valid API? Good to know.

What I don't know: Can it be product specific? So the net people
ship a version for new networking APIs and filesystem people ship
new filesystem methods along with their filesystem support.

Reason I ask: There are many such frameworks floating around, but
none was complete. Many miss BUG_ON(), likely()/unlikely(),
seq_file support and many more interesting stuff.

Regards

Ingo Oeser
-- 
Marketing ist die Kunst, Leuten Sachen zu verkaufen, die sie
nicht brauchen, mit Geld, was sie nicht haben, um Leute zu
beeindrucken, die sie nicht moegen.

Re: [PATCH] compatmac is not needed

[David Woodhouse]

On Wed, 2003-04-09 at 17:03, Ingo Oeser wrote:
> So this is still a valid API? Good to know.
> 
> What I don't know: Can it be product specific? So the net people
> ship a version for new networking APIs and filesystem people ship
> new filesystem methods along with their filesystem support.
> 
> Reason I ask: There are many such frameworks floating around, but
> none was complete. Many miss BUG_ON(), likely()/unlikely(),
> seq_file support and many more interesting stuff.

Well, my copy of include/linux/mtd/compatmac.h includes just about
everything needed to get the CVS MTD code, which is meant for 2.5, to
build and work on 2.4. 

There's definitely some scope for merging the various hacks if you're so
inclined.

-- 
dwmw2