kernel panic with 2.5.67-ac1

kernel panic with 2.5.67-ac1

[Christian Staudenmayer]

hello,

i recently compiled 2.5.67-ac1 on my machine which uses the
aic7xxx driver for an old adaptec 2940 scsi controller.
When booting, the kernel panics after loading the scsi driver
with the following message:

Process swapper (pid: 1, threadinfo=dbf8e000 task=dbf8c040)
Stack: c15259a8 c15259a8 00000001 00000002 dbf8fe48 c022cd1a c15259a8 000000ff
       dbf8fe3c dbf8fe40
Call Trace:
 [<c022cd1a>] ide_xlate_1024+0x106/0x18c
 [<c01654aa>] handle_ide_mess+0x14e/0x1e8
 [<c016557f>] msdos_partition+0x3b/0x3ec
 [<c01171fa>] release_console_sem+0x32/0x94
 [<c0117165>] printk+0xfd/0x114
 [<c016491d>] check_partition+0xa1/0xec
 [<c0164c13>] register_disk+0xa7/0x144
 [<c0164c28>] register_disk+0xbc/0x144
 [<c0218301>] add_disk+0x35/0x44
 [<c021829c>] exact_match+0x0/0xc
 [<c02182a8>] exact_lock+0x0/0x24
 [<c0273589>] sd_attach+0x1d/0x244
 [<c023d9c0>] scsi_register_device+0xb8/0xe4
 [<c010502c>] init+0x0/0x144
 [<c0105049>] init+0x1d/0x144
 [<c010502c>] init+0x0/0x144
 [<c01079c1>] kernel_thread_helper+0x5/0xc

Code: 8b 40 38 be 93 74 31 c0 ff d0 89 c1 c7 03 3f 00 00 00 85 ff
 <0>Kernel panic: Attempted to kill init!

Note: this does not happen with 2.4.20, 2.4.21-pre7, 2.4.21-pre7-ac1 or 2.5.67-bk8
It does, however happen with 2.5.67-ac2, but the error message is some lines longer
and some of the addresses have changed.

I'd be really grateful for any insight on this problem.

Greetings, Chris


__________________________________________________
Do you Yahoo!?
Yahoo! Platinum - Watch CBS' NCAA March Madness, live on your desktop!
http://platinum.yahoo.com

Re: kernel panic with 2.5.67-ac1

[Patrick Mansfield]

On Fri, Apr 18, 2003 at 10:18:06AM -0700, Christian Staudenmayer wrote:
> Note: this does not happen with 2.4.20, 2.4.21-pre7, 2.4.21-pre7-ac1 or 2.5.67-bk8
> It does, however happen with 2.5.67-ac2, but the error message is some lines longer
> and some of the addresses have changed.
> 
> I'd be really grateful for any insight on this problem.

We were plugging a queue that was about to be freed during scsi scan.

This is fixed in bk8, here is a snippit of part of the patch to scsi_lib.c
that fixed the problem, or look at the end of scsi_prep_fn, (plus the
corresponding call to blk_plug_device was removed from scsi_request_fn):

+ defer:
+       /* If we defer, the elv_next_request() returns NULL, but the
+        * queue must be restarted, so we plug here if no returning
+        * command will automatically do that. */
+       if (sdev->device_busy == 0)
+               blk_plug_device(q);
+       return BLKPREP_DEFER;
+}

-- Patrick Mansfield

Re: kernel panic with 2.5.67-ac1

[Christian Staudenmayer]

Hello,

as i mentioned, the panic also appears in 2.5.67-ac2, just in a slightly different
variant. However, the fix from bk8 you mentioned _is_ in 2.5.67-ac2 (or at least
the snippit of code that you posted).
So this probably isn't the problem here, is it?

Thanks in advance,
Christian Staudenmayer

--- Patrick Mansfield <patmans@us.ibm.com> wrote:
> On Fri, Apr 18, 2003 at 10:18:06AM -0700, Christian Staudenmayer wrote:
> > Note: this does not happen with 2.4.20, 2.4.21-pre7, 2.4.21-pre7-ac1 or 2.5.67-bk8
> > It does, however happen with 2.5.67-ac2, but the error message is some lines longer
> > and some of the addresses have changed.
> > 
> > I'd be really grateful for any insight on this problem.
> 
> We were plugging a queue that was about to be freed during scsi scan.
> 
> This is fixed in bk8, here is a snippit of part of the patch to scsi_lib.c
> that fixed the problem, or look at the end of scsi_prep_fn, (plus the
> corresponding call to blk_plug_device was removed from scsi_request_fn):
> 
> + defer:
> +       /* If we defer, the elv_next_request() returns NULL, but the
> +        * queue must be restarted, so we plug here if no returning
> +        * command will automatically do that. */
> +       if (sdev->device_busy == 0)
> +               blk_plug_device(q);
> +       return BLKPREP_DEFER;
> +}
> 
> -- Patrick Mansfield


__________________________________________________
Do you Yahoo!?
Yahoo! Platinum - Watch CBS' NCAA March Madness, live on your desktop!
http://platinum.yahoo.com

Re: kernel panic with 2.5.67-ac1

[Patrick Mansfield]

On Fri, Apr 18, 2003 at 03:15:52PM -0700, Christian Staudenmayer wrote:
> Hello,
> 
> as i mentioned, the panic also appears in 2.5.67-ac2, just in a slightly different
> variant. However, the fix from bk8 you mentioned _is_ in 2.5.67-ac2 (or at least
> the snippit of code that you posted).
> So this probably isn't the problem here, is it?

No you're right it isn't, I should have looked closer.

-- Patrick Mansfield