From: Andrew Morton <akpm@digeo.com>
To: Keith Mannthey <kmannth@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] clustered apic irq affinity fix for i386
Date: Wed, 30 Apr 2003 19:22:05 -0700 [thread overview]
Message-ID: <20030430192205.13491d61.akpm@digeo.com> (raw)
In-Reply-To: <1051751157.16886.91.camel@dyn9-47-17-180.beaverton.ibm.com>
Keith Mannthey <kmannth@us.ibm.com> wrote:
>
> This should be better. Thanks for the comments.
Remind me again what the patch actually does? It seems to be purely adding
debug checks?
Won't it just go BUG if someone boots the kernel and then tries to manually
set affinity?
Seems a bit racy too. setup_ioapic_dest() does:
pending_irq_balance_apicid[irq] = mask;
==> window here
set_ioapic_affinity(irq, mask);
ioapic_lock is not held, so there is a window where
pending_irq_balance_apicid[irq] can be set to some other value and
io_apic_write_affinity() will accidentally go BUG.
Is it not possible to fix set_ioapic_affinity() for real for clustered APIC
mode? What is involved in that?
next prev parent reply other threads:[~2003-05-01 2:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-30 23:07 Keith Mannthey
2003-04-30 23:36 ` Andrew Morton
2003-05-01 1:05 ` Keith Mannthey
2003-05-01 2:22 ` Andrew Morton [this message]
2003-05-01 2:49 ` William Lee Irwin III
2003-05-01 4:07 ` Martin J. Bligh
2003-05-01 17:51 ` Keith Mannthey
2003-05-06 0:04 ` [RFC][PATCH] fix for clusterd io_apics Keith Mannthey
2003-05-06 15:15 ` Martin J. Bligh
2003-05-01 9:10 ` [RFC] clustered apic irq affinity fix for i386 Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030430192205.13491d61.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=kmannth@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®