[PATCH] Linux 2.5.68 - Fix FreeXid after return in fs/cifs/inode.c

[PATCH] Linux 2.5.68 - Fix FreeXid after return in fs/cifs/inode.c

[Gabriel Devenyi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This patch applies to 2.5.68, it is listed at kbugs.org. FreeXid(xid); is after return so it is never executed.

Please CC me with any discussion.
- -- 
Building the Future,
Gabriel Devenyi
devenyga@mcmaster.ca

- ---FILE---

- --- linux-2.5.68/fs/cifs/inode.c	2003-04-19 22:48:49.000000000 -0400
+++ linux-2.5.68-changed/fs/cifs/inode.c	2003-05-01 15:10:32.000000000 -0400
@@ -450,10 +450,10 @@
 	cifs_sb_source = CIFS_SB(source_inode->i_sb);
 	pTcon = cifs_sb_source->tcon;
 
- -	if (pTcon != cifs_sb_target->tcon) {    
+	if (pTcon != cifs_sb_target->tcon) {
+		FreeXid(xid);
 		return -EXDEV;	/* BB actually could be allowed if same server, but
                      different share. Might eventually add support for this */
- -        	FreeXid(xid);
 	}
 
 	fromName = build_path_from_dentry(source_direntry);

- ---ENDFILE---
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+sX297I5UBdiZaF4RAmZdAKCMDNHfhNlT3aUsuuVvPAp3Qae7TwCbBXJe
JfPpUBFc/wfsuUa9WfBFuZk=
=wm6g
-----END PGP SIGNATURE-----

Re: [PATCH] Linux 2.5.68 - Fix FreeXid after return in fs/cifs/inode.c

[Steven French]

The fix to fs/cifs/inode.c that you reference is integrated already into
the 2.5
bitkeeper tree and should be in 2.5,69 (the change was picked up as part of
five cifs vfs
changesets that were integrated last week)

>This patch applies to 2.5.68, it is listed at kbugs.org. FreeXid(xid); is
after return
>so it is never executed.
>
>Gabriel Devenyi
>
>
>- ---FILE---
>
>- --- linux-2.5.68/fs/cifs/inode.c 2003-04-19 22:48:49.000000000 -0400
>+++ linux-2.5.68-changed/fs/cifs/inode.c 2003-05-01 15:10:32.000000000
-0400
>@@ -450,10 +450,10 @@

Steve French
Senior Software Engineer
Linux Technology Center - IBM Austin
phone: 512-838-2294
email: sfrench@us.ibm.com