From: Jan Harkes <jaharkes@cs.cmu.edu>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: Andrew Morton <akpm@digeo.com>, linux-kernel@vger.kernel.org
Subject: Re: PATCH - Don't remove inode from hash until filesystem has deleted it.
Date: Thu, 8 May 2003 16:43:34 -0400 [thread overview]
Message-ID: <20030508204334.GA8577@delft.aura.cs.cmu.edu> (raw)
In-Reply-To: <16057.46720.778667.845306@notabene.cse.unsw.edu.au>
On Thu, May 08, 2003 at 11:44:32AM +1000, Neil Brown wrote:
> ------------------------------------------------------
> Don't remove inode from hash until filesystem has deleted it.
>
> With this patch, the inode being deleted is left on the hash table,
> and if a lookup find an inode being freed in the hashtable, it waits
> in the inode waitqueue for the inode to be fully deleted.
I could be wrong, but won't that break the following sequence of
operations,
mkdir("foo", 0755);
fd = creat("foo/bar", 0644);
unlink("foo/bar");
rmdir("foo"); /* this should succeed, but if the file is hashed
we get EBUSY here */
close(fd);
Or have potential deadlock effects when rmdir is replaced with some
operation that tries to perform a lookup for the inode, f.i. a
stat("foo/bar", &statbuf);
Jan
next prev parent reply other threads:[~2003-05-08 20:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-08 1:44 Neil Brown
2003-05-08 20:43 ` Jan Harkes [this message]
2003-05-09 4:36 ` Neil Brown
2003-05-09 8:06 ` David Woodhouse
2003-05-09 22:24 ` Andrew Morton
2003-05-12 0:41 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030508204334.GA8577@delft.aura.cs.cmu.edu \
--to=jaharkes@cs.cmu.edu \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®