From: Christoph Hellwig <hch@infradead.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: ioctl32: kill code duplication (sparc64 tester wanted)
Date: Mon, 12 May 2003 14:08:34 +0100 [thread overview]
Message-ID: <20030512140834.A29260@infradead.org> (raw)
In-Reply-To: <20030512130518.GA15227@atrey.karlin.mff.cuni.cz>; from pavel@ucw.cz on Mon, May 12, 2003 at 03:05:19PM +0200
On Mon, May 12, 2003 at 03:05:19PM +0200, Pavel Machek wrote:
> Hi!
> > I don't have a sparc64, but there's certainly no <asm/mtrr.h> for
> > > that arch..
>
> I thought I killed that one?
The patch you attached added it..
> > Also #including c files is ugly as hell. What's the #ifdef INCLUDES
> > supposed to help?
>
> Yes, but do you have better proposal how to kill 4000+ lines of code
> from each 64-bit architecture?
What's the reason you can't build fs/compat_ioctl.c normally and pull
in the arch magic through a magic asm/ header? You still haven't answered
the second question, btw..
next prev parent reply other threads:[~2003-05-12 12:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-12 11:40 Pavel Machek
2003-05-12 12:43 ` Christoph Hellwig
2003-05-12 13:05 ` Pavel Machek
2003-05-12 13:08 ` Christoph Hellwig [this message]
2003-05-12 13:13 ` Pavel Machek
2003-05-12 13:16 ` Christoph Hellwig
2003-05-12 14:19 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030512140834.A29260@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®