* Preemption fixes for x86 MSR driver.
@ 2003-05-15 3:31 davej
0 siblings, 0 replies; only message in thread
From: davej @ 2003-05-15 3:31 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel
wrmsr is ok, but needs cleans up, second part (rdmsr)
is currently broken.
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/arch/i386/kernel/msr.c linux-2.5/arch/i386/kernel/msr.c
--- bk-linus/arch/i386/kernel/msr.c 2003-04-10 06:01:09.000000000 +0100
+++ linux-2.5/arch/i386/kernel/msr.c 2003-04-06 23:05:55.000000000 +0100
@@ -120,8 +120,6 @@ static inline int do_wrmsr(int cpu, u32
preempt_disable();
if ( cpu == smp_processor_id() ) {
ret = wrmsr_eio(reg, eax, edx);
- preempt_enable();
- return ret;
} else {
cmd.cpu = cpu;
cmd.reg = reg;
@@ -129,17 +127,20 @@ static inline int do_wrmsr(int cpu, u32
cmd.data[1] = edx;
smp_call_function(msr_smp_wrmsr, &cmd, 1, 1);
- preempt_enable();
- return cmd.err;
+ ret = cmd.err;
}
+ preempt_enable();
+ return ret;
}
static inline int do_rdmsr(int cpu, u32 reg, u32 *eax, u32 *edx)
{
struct msr_command cmd;
+ int ret;
+ preempt_disable();
if ( cpu == smp_processor_id() ) {
- return rdmsr_eio(reg, eax, edx);
+ ret = rdmsr_eio(reg, eax, edx);
} else {
cmd.cpu = cpu;
cmd.reg = reg;
@@ -149,8 +150,10 @@ static inline int do_rdmsr(int cpu, u32
*eax = cmd.data[0];
*edx = cmd.data[1];
- return cmd.err;
+ ret = cmd.err;
}
+ preempt_enable();
+ return ret;
}
#else /* ! CONFIG_SMP */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-05-15 3:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-15 3:31 Preemption fixes for x86 MSR driver davej
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®