* [PATCH] fix vsyscall page core dump segment size
@ 2003-05-16 8:40 Roland McGrath
0 siblings, 0 replies; only message in thread
From: Roland McGrath @ 2003-05-16 8:40 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel
My change to core dumps that was included with the vsyscall DSO
implementation had a bug (braino on my part). Core dumps don't include the
full page of the vsyscall DSO, and so don't accurately represent the whole
memory image of the process. This patch fixes it.
arch/x86_64/ia32/ia32_binfmt.c's copy of this code needs the corresponding
update as well. I don't include a patch since that code is not in the main
tree.
Thanks,
Roland
--- linux-2.5.69/include/asm-i386/elf.h.~1~ Sun May 4 16:53:35 2003
+++ linux-2.5.69/include/asm-i386/elf.h Thu May 15 23:39:22 2003
@@ -149,7 +149,10 @@ do { \
for (i = 0; i < VSYSCALL_EHDR->e_phnum; ++i) { \
struct elf_phdr phdr = vsyscall_phdrs[i]; \
if (phdr.p_type == PT_LOAD) { \
+ BUG_ON(ofs != 0); \
ofs = phdr.p_offset = offset; \
+ phdr.p_filesz = PAGE_ALIGN(phdr.p_filesz); \
+ phdr.p_memsz = PAGE_ALIGN(phdr.p_memsz); \
offset += phdr.p_filesz; \
} \
else \
@@ -167,7 +170,7 @@ do { \
for (i = 0; i < VSYSCALL_EHDR->e_phnum; ++i) { \
if (vsyscall_phdrs[i].p_type == PT_LOAD) \
DUMP_WRITE((void *) vsyscall_phdrs[i].p_vaddr, \
- vsyscall_phdrs[i].p_filesz); \
+ PAGE_ALIGN(vsyscall_phdrs[i].p_filesz)); \
} \
} while (0)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-05-16 8:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-16 8:40 [PATCH] fix vsyscall page core dump segment size Roland McGrath
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®