[RFC] [PATCH] Add 'make' with no target as preferred build command

[RFC] [PATCH] Add 'make' with no target as preferred build command

[Paulo Andre']

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

Hello,

It seems for 2.5/2.6 'make' is the preferred command for building the
kernel tree (also stated in davej's 2.6 "what to expect" document). That
scenario however isn't even presented when the user finishes the kernel
configuration. This is a simple patch to scripts/kconfig/mconf.c which
tackles that, perhaps not in the best fashion but certainly in the
simplest.

Applies on top of bk-curr. Please consider.


		Paulo Andre'



[-- Attachment #2: patch-scripts_kconfig_mconf.c.diff --]
[-- Type: text/plain, Size: 571 bytes --]

--- linux-2.5-vanilla/scripts/kconfig/mconf.c	2003-03-24 22:00:10.000000000 +0000
+++ linux-2.5/scripts/kconfig/mconf.c	2003-05-26 12:49:13.000000000 +0100
@@ -781,7 +781,7 @@
 		printf("\n\n"
 			"*** End of Linux kernel configuration.\n"
 			"*** Check the top-level Makefile for additional configuration.\n"
-			"*** Next, you may run 'make bzImage', 'make bzdisk', or 'make install'.\n\n");
+			"*** Next, you may run 'make', 'make bzImage', 'make bzdisk', or 'make install'.\n\n");
 	} else
 		printf("\n\nYour kernel configuration changes were NOT saved.\n\n");
 

Re: [RFC] [PATCH] Add 'make' with no target as preferred build command

[Sam Ravnborg]

On Mon, May 26, 2003 at 06:29:07PM +0100, Paulo Andre' wrote:
> Hello,
> 
> It seems for 2.5/2.6 'make' is the preferred command for building the
> kernel tree (also stated in davej's 2.6 "what to expect" document). That
> scenario however isn't even presented when the user finishes the kernel
> configuration. This is a simple patch to scripts/kconfig/mconf.c which
> tackles that, perhaps not in the best fashion but certainly in the
> simplest.

If we really want this boilerplate text then bzImage should not be
present. It is i386 centric.
Revised patch below. Also made it a bit more readable by wrapping
a long line.

Roman Zippel cc:ed as he is the kconfig maintainer.

	Sam

===== scripts/kconfig/mconf.c 1.5 vs edited =====
--- 1.5/scripts/kconfig/mconf.c	Sat Mar 15 18:25:55 2003
+++ edited/scripts/kconfig/mconf.c	Mon May 26 22:30:47 2003
@@ -780,10 +780,12 @@
 		conf_write(NULL);
 		printf("\n\n"
 			"*** End of Linux kernel configuration.\n"
-			"*** Check the top-level Makefile for additional configuration.\n"
-			"*** Next, you may run 'make bzImage', 'make bzdisk', or 'make install'.\n\n");
+			"*** Execute 'make' to build the kernel"
+		        " or try 'make help'.\n\n");
 	} else
-		printf("\n\nYour kernel configuration changes were NOT saved.\n\n");
+		printf("\n\n"
+			"*** Your kernel configuration changes were NOT saved."
+			"\n\n");
 
 	return 0;
 }

Re: [RFC] [PATCH] Add 'make' with no target as preferred build command

[Paulo Andre']

On Mon, 26 May 2003 22:34:43 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:

> If we really want this boilerplate text then bzImage should not be
> present. It is i386 centric.
> Revised patch below. Also made it a bit more readable by wrapping
> a long line.

Agreed.

> Roman Zippel cc:ed as he is the kconfig maintainer.

I apologize for not having cc'ed Roman Zippel in the first place. It
sounded like too simple a fix. My bad, and for that I'm sorry.

		Paulo

Re: [RFC] [PATCH] Add 'make' with no target as preferred build command

[Roman Zippel]

Hi,

On Mon, 26 May 2003, Sam Ravnborg wrote:

> If we really want this boilerplate text then bzImage should not be
> present. It is i386 centric.
> Revised patch below. Also made it a bit more readable by wrapping
> a long line.

Looks good, thanks.

bye, Roman