* Re: [PATCH] mark shrinkable slabs as being reclaimable
[not found] <200305252319.h4PNJkpJ027852@hera.kernel.org>
@ 2003-05-27 22:31 ` David Woodhouse
2003-05-27 22:38 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: David Woodhouse @ 2003-05-27 22:31 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: akpm
On Sun, 2003-05-25 at 23:11, Linux Kernel Mailing List wrote:
> ChangeSet 1.1308, 2003/05/25 15:11:47-07:00, akpm@digeo.com
>
> [PATCH] mark shrinkable slabs as being reclaimable
>
> All slabs which can be reclaimed via VM presure are marked as being
> shrinkable, so the core slab code will keep count of their pages.
If my understanding of this is correct -- stuff that will be freed on
prune_icache() or other memory pressure should be marked such -- then...
> diff -Nru a/fs/jffs/inode-v23.c b/fs/jffs/inode-v23.c
> --- a/fs/jffs/inode-v23.c Sun May 25 16:19:51 2003
> +++ b/fs/jffs/inode-v23.c Sun May 25 16:19:51 2003
> @@ -1806,9 +1806,11 @@
> jffs_proc_root = proc_mkdir("jffs", proc_root_fs);
> #endif
> fm_cache = kmem_cache_create("jffs_fm", sizeof(struct jffs_fm),
> - 0, SLAB_HWCACHE_ALIGN, NULL, NULL);
> + 0, SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT,
> + NULL, NULL);
No.
> node_cache = kmem_cache_create("jffs_node",sizeof(struct jffs_node),
> - 0, SLAB_HWCACHE_ALIGN, NULL, NULL);
> + 0, SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT,
> + NULL, NULL);
No.
> diff -Nru a/fs/jffs2/malloc.c b/fs/jffs2/malloc.c
> --- a/fs/jffs2/malloc.c Sun May 25 16:19:51 2003
> +++ b/fs/jffs2/malloc.c Sun May 25 16:19:51 2003
> @@ -73,7 +73,8 @@
>
> inode_cache_slab = kmem_cache_create("jffs2_inode_cache",
> sizeof(struct jffs2_inode_cache),
> - 0, JFFS2_SLAB_POISON, NULL, NULL);
> + 0, JFFS2_SLAB_POISON|SLAB_RECLAIM_ACCOUNT,
> + NULL, NULL);
No.
> --- a/fs/jffs2/super.c Sun May 25 16:19:51 2003
> +++ b/fs/jffs2/super.c Sun May 25 16:19:51 2003
> @@ -299,7 +299,7 @@
>
> jffs2_inode_cachep = kmem_cache_create("jffs2_i",
> sizeof(struct jffs2_inode_info),
> - 0, SLAB_HWCACHE_ALIGN,
> + 0, SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT,
> jffs2_i_init_once, NULL);
Yes.
--
dwmw2
^ permalink raw reply [flat|nested] 2+ messages in thread