mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* RE: [PATCH] Make ACPI compile again on 64bit/gcc 3.3 II
@ 2003-05-27 20:31 Grover, Andrew
  2003-05-27 21:04 ` Andi Kleen
  0 siblings, 1 reply; 4+ messages in thread
From: Grover, Andrew @ 2003-05-27 20:31 UTC (permalink / raw)
  To: Andi Kleen; +Cc: torvalds, linux-kernel

> From: Andi Kleen [mailto:ak@suse.de] 
> Sent: Saturday, May 24, 2003 3:40 PM
> To: Grover, Andrew
> Cc: Andi Kleen; torvalds@transmeta.com; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] Make ACPI compile again on 64bit/gcc 3.3 II
> 
> 
> On Sat, May 24, 2003 at 01:55:26PM -0700, Grover, Andrew wrote:
> > Actually, I think osl.c should be changed to match the header as it
> > stands. Could you try that and see if that also fixes things?
> 
> On looking again these functions are not used at all.
> How about just removing them? 

We will remove them for the next release.

Thanks -- Regards -- Andy

^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH] Make ACPI compile again on 64bit/gcc 3.3 II
@ 2003-05-27 21:12 Grover, Andrew
  0 siblings, 0 replies; 4+ messages in thread
From: Grover, Andrew @ 2003-05-27 21:12 UTC (permalink / raw)
  To: Andi Kleen; +Cc: torvalds, linux-kernel

> From: Andi Kleen [mailto:ak@suse.de] 
> > > On looking again these functions are not used at all.
> > > How about just removing them? 
> > 
> > We will remove them for the next release.
> 
> But can you merge one of the patches for now to make it compile again?
> 
> -Andi

I thought Linus already took your patch, so that'll work for now, yes?

-- Andy

^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH] Make ACPI compile again on 64bit/gcc 3.3
@ 2003-05-24 20:55 Grover, Andrew
  2003-05-24 22:39 ` [PATCH] Make ACPI compile again on 64bit/gcc 3.3 II Andi Kleen
  0 siblings, 1 reply; 4+ messages in thread
From: Grover, Andrew @ 2003-05-24 20:55 UTC (permalink / raw)
  To: Andi Kleen, torvalds, linux-kernel

Actually, I think osl.c should be changed to match the header as it
stands. Could you try that and see if that also fixes things?

Thanks -- Regards -- Andy

> From: Andi Kleen [mailto:ak@suse.de] 
> Without this patch ACPI in BK-CVS current does not compile on 
> AMD64/gcc 3.3.
> 
> -Andi
> 
> 
> Index: linux/include/acpi/acpiosxf.h
> ===================================================================
> RCS file: /home/cvs/linux-2.5/include/acpi/acpiosxf.h,v
> retrieving revision 1.7
> diff -u -u -r1.7 acpiosxf.h
> --- linux/include/acpi/acpiosxf.h	24 May 2003 01:49:28 
> -0000	1.7
> +++ linux/include/acpi/acpiosxf.h	24 May 2003 07:32:37 -0000
> @@ -287,15 +287,15 @@
>   * Miscellaneous
>   */
>  
> -u8
> +BOOLEAN
>  acpi_os_readable (
>  	void                            *pointer,
> -	acpi_size                       length);
> +	u32                       	length);
>  
> -u8
> +BOOLEAN
>  acpi_os_writable (
>  	void                            *pointer,
> -	acpi_size                       length);
> +	u32                       	length);
>  
>  u32
>  acpi_os_get_timer (
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-05-27 20:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-27 20:31 [PATCH] Make ACPI compile again on 64bit/gcc 3.3 II Grover, Andrew
2003-05-27 21:04 ` Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2003-05-27 21:12 Grover, Andrew
2003-05-24 20:55 [PATCH] Make ACPI compile again on 64bit/gcc 3.3 Grover, Andrew
2003-05-24 22:39 ` [PATCH] Make ACPI compile again on 64bit/gcc 3.3 II Andi Kleen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®