From: Andrew Morton <akpm@digeo.com>
To: Paul Fulghum <paulkf@microgate.com>
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [BUGS] 2.5.69 syncppp
Date: Wed, 28 May 2003 14:54:51 -0700 [thread overview]
Message-ID: <20030528145451.5f13ebab.akpm@digeo.com> (raw)
In-Reply-To: <1054157063.2279.2.camel@diemos>
Paul Fulghum <paulkf@microgate.com> wrote:
>
> Was it really the intention of the change to kernel/softirq.c:105
> (source of the warning) that callers to dev_queue_xmit()
> not be allowed to use spinlocks? If so, then what other
> synchronization techniques are appropriate for use in
> an interrupt and timer context?
That warning is there because local_bh_enable will unconditionally enable
interrupts, to run softirqs.
Hence, if someone is calling local_bh_enable() with interrupts disabled
then local_bh_enable() is about to break their locking scheme in subtle
ways. So the warning is there to tell you about this.
And we don't want to be running softirqs with interrupts disabled, for
latency reasons.
prev parent reply other threads:[~2003-05-28 21:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-23 21:15 Paul Fulghum
2003-05-23 21:31 ` Andrew Morton
2003-05-23 23:11 ` Paul Fulghum
2003-05-26 17:42 ` Alan Cox
2003-05-28 21:24 ` Paul Fulghum
2003-05-28 21:37 ` Alan Cox
2003-05-28 21:54 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030528145451.5f13ebab.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=paulkf@microgate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®