From: "Paul Fulghum" <paulkf@microgate.com>
To: "Andrew Morton" <akpm@digeo.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: [BUGS] 2.5.69 syncppp
Date: Fri, 23 May 2003 18:11:02 -0500 [thread overview]
Message-ID: <OPENKONOOJPFMJFAJLHAKEPCCBAA.paulkf@microgate.com> (raw)
In-Reply-To: <20030523143138.4701982e.akpm@digeo.com>
> sppp_lcp_open() is called from other places
> without that lock held, so it is probably not
> totally stupid to drop it in the timer handler too.
That section was previously covered by cli/sti,
and I changed it to use the spinlock instead
when cli/sti went away in 2.5.x.
I thought it was in place to serialize state changes.
I'll look at it harder, you may be right in that
it is not necessary.
> It's good (and surprising) that someone is
> actually using that stuff.
It's not pretty, but it works.
Some customers prefer it to pppd.
> Please beat on it for a while.
Yes, that code is in need of a good beating :-)
Paul Fulghum
paulkf@microgate.com
next prev parent reply other threads:[~2003-05-23 22:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-23 21:15 Paul Fulghum
2003-05-23 21:31 ` Andrew Morton
2003-05-23 23:11 ` Paul Fulghum [this message]
2003-05-26 17:42 ` Alan Cox
2003-05-28 21:24 ` Paul Fulghum
2003-05-28 21:37 ` Alan Cox
2003-05-28 21:54 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OPENKONOOJPFMJFAJLHAKEPCCBAA.paulkf@microgate.com \
--to=paulkf@microgate.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®