From: Andi Kleen <ak@suse.de>
To: akpm@digeo.com
Cc: johnstul@us.ibm.com, linux-kernel@vger.kernel.org
Subject: [PATCH] More irq balance fixes
Date: Sat, 31 May 2003 13:52:52 +0200 [thread overview]
Message-ID: <20030531115252.GA10245@wotan.suse.de> (raw)
John Stultz noticed that kirqd didn't start because of another logic error,
which broke irq balancing. This was still a fallout from the generic
subarchitecture changes.
Actually it still refuses to balance anything on my test box, but perhaps
I'm just not able to generate enough interrupts.
Anyways, with this patch the thread is running again at least.
-Andi
Index: linux/arch/i386/kernel/io_apic.c
===================================================================
RCS file: /home/cvs/linux-2.5/arch/i386/kernel/io_apic.c,v
retrieving revision 1.72
diff -u -u -r1.72 io_apic.c
--- linux/arch/i386/kernel/io_apic.c 30 May 2003 20:11:58 -0000 1.72
+++ linux/arch/i386/kernel/io_apic.c 31 May 2003 10:24:18 -0000
@@ -352,16 +352,8 @@
unsigned long allowed_mask;
unsigned int new_cpu;
- if (irqbalance_disabled == IRQBALANCE_CHECK_ARCH)
- irqbalance_disabled = NO_BALANCE_IRQ;
- if (irqbalance_disabled) {
- static int warned;
- if (warned == 0) {
- printk("irqbalance disabled\n");
- warned = 1;
- }
+ if (irqbalance_disabled)
return;
- }
allowed_mask = cpu_online_map & irq_affinity[irq];
new_cpu = move(cpu, allowed_mask, now, 1);
@@ -620,6 +612,9 @@
struct cpuinfo_x86 *c;
c = &boot_cpu_data;
+ /* When not overwritten by the command line ask subarchitecture. */
+ if (irqbalance_disabled == IRQBALANCE_CHECK_ARCH)
+ irqbalance_disabled = NO_BALANCE_IRQ;
if (irqbalance_disabled)
return 0;
reply other threads:[~2003-05-31 11:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030531115252.GA10245@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@digeo.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®