mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] More irq balance fixes
@ 2003-05-31 11:52 Andi Kleen
  0 siblings, 0 replies; only message in thread
From: Andi Kleen @ 2003-05-31 11:52 UTC (permalink / raw)
  To: akpm; +Cc: johnstul, linux-kernel


John Stultz noticed that kirqd didn't start because of another logic error,
which broke irq balancing.  This was still a fallout from the generic 
subarchitecture changes.

Actually it still refuses to balance anything on my test box, but perhaps
I'm just not able to generate enough interrupts.

Anyways, with this patch the thread is running again at least.

-Andi


Index: linux/arch/i386/kernel/io_apic.c
===================================================================
RCS file: /home/cvs/linux-2.5/arch/i386/kernel/io_apic.c,v
retrieving revision 1.72
diff -u -u -r1.72 io_apic.c
--- linux/arch/i386/kernel/io_apic.c	30 May 2003 20:11:58 -0000	1.72
+++ linux/arch/i386/kernel/io_apic.c	31 May 2003 10:24:18 -0000
@@ -352,16 +352,8 @@
 	unsigned long allowed_mask;
 	unsigned int new_cpu;
 		
-	if (irqbalance_disabled == IRQBALANCE_CHECK_ARCH)
-		irqbalance_disabled = NO_BALANCE_IRQ;
-	if (irqbalance_disabled) { 
-		static int warned;
-		if (warned == 0) {
-			printk("irqbalance disabled\n");
-			warned = 1;
-		} 
+	if (irqbalance_disabled)
 		return; 
-	} 
 
 	allowed_mask = cpu_online_map & irq_affinity[irq];
 	new_cpu = move(cpu, allowed_mask, now, 1);
@@ -620,6 +612,9 @@
 	struct cpuinfo_x86 *c;
 
         c = &boot_cpu_data;
+	/* When not overwritten by the command line ask subarchitecture. */
+	if (irqbalance_disabled == IRQBALANCE_CHECK_ARCH)
+		irqbalance_disabled = NO_BALANCE_IRQ;
 	if (irqbalance_disabled)
 		return 0;
 	


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-05-31 11:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-31 11:52 [PATCH] More irq balance fixes Andi Kleen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®