* shmctl(SHM_LOCK/UNLOCK) deadlock
@ 2003-06-04 13:48 Andrea Arcangeli
0 siblings, 0 replies; only message in thread
From: Andrea Arcangeli @ 2003-06-04 13:48 UTC (permalink / raw)
To: linux-kernel; +Cc: Marcelo Tosatti
Hi,
this patch fixes an SMP deadlock that triggered in some production
usage:
--- xxx/mm/shmem.c.~1~ 2003-06-01 19:14:07.000000000 +0200
+++ xxx/mm/shmem.c 2003-06-04 02:17:23.000000000 +0200
@@ -808,9 +808,9 @@ void shmem_lock(struct file * file, int
struct inode * inode = file->f_dentry->d_inode;
struct shmem_inode_info * info = SHMEM_I(inode);
- down(&info->sem);
+ spin_lock(&info->lock);
info->locked = lock;
- up(&info->sem);
+ spin_unlock(&info->lock);
}
int shmem_make_bigpage_mmap(struct file * file, struct vm_area_struct * vma)
you can merge it in 21-final IMHO (even dropping the lock enterely would
been ok, the reader is out of order anyways and that's atomic stuff in C
no matter the architecture)
Andrea
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-06-04 13:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-06-04 13:48 shmctl(SHM_LOCK/UNLOCK) deadlock Andrea Arcangeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®