* [PATCH] typo in new class_device_release
@ 2003-06-05 18:26 Stephen Hemminger
2003-06-05 20:05 ` Patrick Mochel
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2003-06-05 18:26 UTC (permalink / raw)
To: Patrick Mochel, Greg KH; +Cc: linux-kernel
There is a typo in the current 2.5.70 bk version of class_device_release that
was not there in my original patch. By confusing the class and the class_device,
the release function oops. cd->release is always the function itself (class_device_release),
cls->release is the one setup for the class (net_class in my case).
diff -Nru a/drivers/base/class.c b/drivers/base/class.c
--- a/drivers/base/class.c Thu Jun 5 11:21:42 2003
+++ b/drivers/base/class.c Thu Jun 5 11:21:42 2003
@@ -191,7 +191,7 @@
pr_debug("device class '%s': release.\n",cd->class_id);
if (cls->release)
- cd->release(cd);
+ cls->release(cd);
}
static struct kobj_type ktype_class_device = {
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] typo in new class_device_release
2003-06-05 18:26 [PATCH] typo in new class_device_release Stephen Hemminger
@ 2003-06-05 20:05 ` Patrick Mochel
0 siblings, 0 replies; 2+ messages in thread
From: Patrick Mochel @ 2003-06-05 20:05 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Greg KH, linux-kernel
On Thu, 5 Jun 2003, Stephen Hemminger wrote:
> There is a typo in the current 2.5.70 bk version of class_device_release that
> was not there in my original patch. By confusing the class and the class_device,
> the release function oops. cd->release is always the function itself (class_device_release),
> cls->release is the one setup for the class (net_class in my case).
Bah, sloppy fixup..
Thanks,
-pat
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-06-05 19:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-06-05 18:26 [PATCH] typo in new class_device_release Stephen Hemminger
2003-06-05 20:05 ` Patrick Mochel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®