From: Sam Ravnborg <sam@ravnborg.org>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Jean Tourrilhes <jt@bougret.hpl.hp.com>,
linux-net@vger.kernel.org, linux-kernel@vger.kernel.org,
trivial@rustcorp.com.au
Subject: Re: [patch] fix vlsi_ir.c compile if !CONFIG_PROC_FS
Date: Sat, 7 Jun 2003 17:58:27 +0200 [thread overview]
Message-ID: <20030607155826.GA20118@mars.ravnborg.org> (raw)
In-Reply-To: <20030607152434.GQ15311@fs.tum.de>
On Sat, Jun 07, 2003 at 05:24:34PM +0200, Adrian Bunk wrote:
> I got the following compile error with !CONFIG_PROC_FS:
> CC drivers/net/irda/vlsi_ir.o
> drivers/net/irda/vlsi_ir.c:2047: `PROC_DIR' undeclared (first use in this function)
> The following patch fixes it:
>
[snip]
I prefer the following patch:
Get rid of one ifdef/endif pair.
Sam
===== drivers/net/irda/vlsi_ir.c 1.16 vs edited =====
--- 1.16/drivers/net/irda/vlsi_ir.c Thu Apr 24 14:17:12 2003
+++ edited/drivers/net/irda/vlsi_ir.c Sat Jun 7 17:55:29 2003
@@ -1993,9 +1993,7 @@
#endif
};
-#ifdef CONFIG_PROC_FS
#define PROC_DIR ("driver/" DRIVER_NAME)
-#endif
static int __init vlsi_mod_init(void)
{
next prev parent reply other threads:[~2003-06-07 15:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-07 15:24 Adrian Bunk
2003-06-07 15:58 ` Sam Ravnborg [this message]
2003-06-07 16:13 ` Adrian Bunk
2003-06-08 9:43 ` Martin Diehl
2003-06-07 16:22 ` Bartlomiej Zolnierkiewicz
2003-06-07 16:59 ` Adrian Bunk
2003-06-07 17:09 ` Sam Ravnborg
2003-06-07 20:09 ` Andrew Morton
2003-06-09 6:00 ` Rusty Russell
2003-06-08 9:40 ` Martin Diehl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030607155826.GA20118@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=bunk@fs.tum.de \
--cc=jt@bougret.hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®