From: Adrian Bunk <bunk@fs.tum.de>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>,
bcollins@debian.org, linux1394-devel@lists.sourceforge.net
Cc: Jean Tourrilhes <jt@bougret.hpl.hp.com>,
linux-net@vger.kernel.org, linux-kernel@vger.kernel.org,
trivial@rustcorp.com.au
Subject: Re: [patch] fix vlsi_ir.c compile if !CONFIG_PROC_FS
Date: Sat, 7 Jun 2003 18:59:51 +0200 [thread overview]
Message-ID: <20030607165951.GA13377@fs.tum.de> (raw)
In-Reply-To: <Pine.SOL.4.30.0306071815120.6449-100000@mion.elka.pw.edu.pl>
On Sat, Jun 07, 2003 at 06:22:39PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> Apply something like this:
>
> --- linux-2.5.70-bk11/include/proc_fs.h Fri Jun 6 18:43:49 2003
> +++ linux/include/proc_fs.h Sat Jun 7 18:11:22 2003
> @@ -205,7 +205,7 @@
> static inline struct proc_dir_entry *create_proc_entry(const char *name,
> mode_t mode, struct proc_dir_entry *parent) { return NULL; }
>
> -static inline void remove_proc_entry(const char *name, struct proc_dir_entry *parent) {};
> +#define remove_proc_entry(name, parent) /* nothing */
> static inline struct proc_dir_entry *proc_symlink(const char *name,
> struct proc_dir_entry *parent,char *dest) {return NULL;}
> static inline struct proc_dir_entry *proc_mknod(const char *name,mode_t mode,
>
> And you wil not have to readd #ifdef/#endif pair.
>
> I've seen Sam's mail but this is generic solution to quiet compiler
> and will work for any remove_proc_entry() user.
Yup, for this specific error Sam's solution is the best one, but your
patch e.g. solves the ieee1394_core.c compile error I reported, too.
> Thanks,
> --
> Bartlomiej
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2003-06-07 16:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-07 15:24 Adrian Bunk
2003-06-07 15:58 ` Sam Ravnborg
2003-06-07 16:13 ` Adrian Bunk
2003-06-08 9:43 ` Martin Diehl
2003-06-07 16:22 ` Bartlomiej Zolnierkiewicz
2003-06-07 16:59 ` Adrian Bunk [this message]
2003-06-07 17:09 ` Sam Ravnborg
2003-06-07 20:09 ` Andrew Morton
2003-06-09 6:00 ` Rusty Russell
2003-06-08 9:40 ` Martin Diehl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030607165951.GA13377@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=bcollins@debian.org \
--cc=jt@bougret.hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®