mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: shemminger@osdl.org
Cc: greg@kroah.com, netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] network hotplug via class_device/kobject
Date: Sun, 15 Jun 2003 00:50:55 -0700 (PDT)	[thread overview]
Message-ID: <20030615.005055.55726223.davem@redhat.com> (raw)
In-Reply-To: <20030613164119.15209934.shemminger@osdl.org>

   From: Stephen Hemminger <shemminger@osdl.org>
   Date: Fri, 13 Jun 2003 16:41:19 -0700

   This patch changes network devices to run hotplug out of the
   kobject/class_device infrastructure rather than calling it from the
   network core. The code gets simpler and there is only one place for
   Greg to fix when he changes the API ;-)

I'll apply this patch, looks fine.
   
   Paranoid about some driver doing something like:
   	rtnl_lock(); register_netdevice(); unregister_netdevice(); rtnl_unlock() BOOM

These sorts of turds exist at least in two places:

1) drivers/net/wan/comx.c
2) drivers/net/wan/hdlc_fr.c

But it is pretty clear that these two drivers have been
tried by nobody in recent years.  They both call into
{un,}register_netdevice without the RTNL semaphore held.

  reply	other threads:[~2003-06-15  7:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-13 23:41 Stephen Hemminger
2003-06-15  7:50 ` David S. Miller [this message]
2003-06-15 10:45   ` Francois Romieu
2003-06-15 19:32   ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030615.005055.55726223.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®