From: Krzysztof Halasa <khc@pm.waw.pl>
To: "David S. Miller" <davem@redhat.com>
Cc: shemminger@osdl.org, greg@kroah.com, netdev@oss.sgi.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] network hotplug via class_device/kobject
Date: 15 Jun 2003 21:32:38 +0200 [thread overview]
Message-ID: <m31xxvgmqx.fsf@defiant.pm.waw.pl> (raw)
In-Reply-To: <20030615.005055.55726223.davem@redhat.com>
"David S. Miller" <davem@redhat.com> writes:
> Paranoid about some driver doing something like:
> rtnl_lock(); register_netdevice(); unregister_netdevice();
> rtnl_unlock() BOOM
>
> These sorts of turds exist at least in two places:
>
> 1) drivers/net/wan/comx.c
> 2) drivers/net/wan/hdlc_fr.c
>
> But it is pretty clear that these two drivers have been
> tried by nobody in recent years. They both call into
> {un,}register_netdevice without the RTNL semaphore held.
Not sure about 1), but 2) calls (un)register_netdevice() with rtnl_lock,
from ioctl.
--
Krzysztof Halasa
Network Administrator
prev parent reply other threads:[~2003-06-15 19:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-13 23:41 Stephen Hemminger
2003-06-15 7:50 ` David S. Miller
2003-06-15 10:45 ` Francois Romieu
2003-06-15 19:32 ` Krzysztof Halasa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31xxvgmqx.fsf@defiant.pm.waw.pl \
--to=khc@pm.waw.pl \
--cc=davem@redhat.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®