* [PATCH 2.4] Fix IrIAP skb leak
@ 2003-06-17 2:08 Jean Tourrilhes
0 siblings, 0 replies; only message in thread
From: Jean Tourrilhes @ 2003-06-17 2:08 UTC (permalink / raw)
To: Marcelo Tosatti, Jeff Garzik, Linux kernel mailing list
ir241_iriap_skb_leak.diff :
<Patch from Jan Kiszka>
o [CORRECT] Fix obvious skb leak in IrIAP state machines
diff -u -p linux/net/irda/iriap_event.d7.c linux/net/irda/iriap_event.c
--- linux/net/irda/iriap_event.d7.c Mon Dec 2 16:24:29 2002
+++ linux/net/irda/iriap_event.c Mon Dec 2 16:25:50 2002
@@ -251,22 +251,25 @@ static void state_s_call(struct iriap_cb
static void state_s_make_call(struct iriap_cb *self, IRIAP_EVENT event,
struct sk_buff *skb)
{
+ struct sk_buff *tx_skb;
+
ASSERT(self != NULL, return;);
switch (event) {
case IAP_CALL_REQUEST:
- skb = self->skb;
+ tx_skb = self->skb;
self->skb = NULL;
- irlmp_data_request(self->lsap, skb);
+ irlmp_data_request(self->lsap, tx_skb);
iriap_next_call_state(self, S_OUTSTANDING);
break;
default:
IRDA_DEBUG(0, "%s(), Unknown event %d\n", __FUNCTION__, event);
- if (skb)
- dev_kfree_skb(skb);
break;
}
+ /* Cleanup time ! */
+ if (skb)
+ dev_kfree_skb(skb);
}
/*
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-06-17 1:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-06-17 2:08 [PATCH 2.4] Fix IrIAP skb leak Jean Tourrilhes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®