From: Andrew Morton <akpm@digeo.com>
To: "Stephen C. Tweedie" <sct@redhat.com>
Cc: roy@karlsbakk.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] O_DIRECT for ext3 (2.4.21)
Date: Tue, 17 Jun 2003 13:01:42 -0700 [thread overview]
Message-ID: <20030617130142.50775749.akpm@digeo.com> (raw)
In-Reply-To: <1055861357.4240.11.camel@sisko.scot.redhat.com>
"Stephen C. Tweedie" <sct@redhat.com> wrote:
>
> Hi,
>
> On Sun, 2003-06-15 at 12:01, Roy Sigurd Karlsbakk wrote:
> > hi all
> >
> > I've been waiting for the official O_DIRECT on ext3 for some time now, so I
> > thought perhaps it's time to get it into 2.4.22 or so. The patch I've used, is
> > the one below (for 2.4.21):
>
> This is Andrea's patch,
Actually I'm the culprit.
> (like allowing direct IO in journaled data mode --- bad move ---
hmm, OK, it doesn't even vaguely work in journalled mode either...
I think the check should be implemented in (the new) ext3_open(). Because
checking the return from open() is the way in which a good application would
determine whether the underlying fs supports O_DIRECT.
Unfortunately O_DIRECT can also be set with fcntl(F_SETFL), and we seem to
have forgotten to provide a way for the fs to be told about fcntl.
next prev parent reply other threads:[~2003-06-17 19:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-15 11:01 Roy Sigurd Karlsbakk
2003-06-15 11:32 ` Matti Aarnio
2003-06-16 8:47 ` Roy Sigurd Karlsbakk
2003-06-17 14:49 ` Stephen C. Tweedie
2003-06-17 20:01 ` Andrew Morton [this message]
2003-06-17 20:19 ` Andrew Morton
2003-06-17 20:46 ` Stephen C. Tweedie
2003-06-19 10:49 ` Roy Sigurd Karlsbakk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030617130142.50775749.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roy@karlsbakk.net \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®