From: Andrew Morton <akpm@digeo.com>
To: sct@redhat.com, roy@karlsbakk.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] O_DIRECT for ext3 (2.4.21)
Date: Tue, 17 Jun 2003 13:19:27 -0700 [thread overview]
Message-ID: <20030617131927.2ac04150.akpm@digeo.com> (raw)
In-Reply-To: <20030617130142.50775749.akpm@digeo.com>
Andrew Morton <akpm@digeo.com> wrote:
>
> I think the check should be implemented in (the new) ext3_open(). Because
> checking the return from open() is the way in which a good application would
> determine whether the underlying fs supports O_DIRECT.
>
> Unfortunately O_DIRECT can also be set with fcntl(F_SETFL), and we seem to
> have forgotten to provide a way for the fs to be told about fcntl.
It works out OK in 2.5, and we should do it this way in 2.4 too:
- dentry_open() checks for inode->i_mapping->a_ops->direct_IO
- setfl() checks for inode->i_mapping->a_ops->direct_IO
- the a_ops for data-journalled inodes have a null ->direct_IO.
next prev parent reply other threads:[~2003-06-17 20:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-15 11:01 Roy Sigurd Karlsbakk
2003-06-15 11:32 ` Matti Aarnio
2003-06-16 8:47 ` Roy Sigurd Karlsbakk
2003-06-17 14:49 ` Stephen C. Tweedie
2003-06-17 20:01 ` Andrew Morton
2003-06-17 20:19 ` Andrew Morton [this message]
2003-06-17 20:46 ` Stephen C. Tweedie
2003-06-19 10:49 ` Roy Sigurd Karlsbakk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030617131927.2ac04150.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roy@karlsbakk.net \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®