From: Andi Kleen <ak@suse.de>
To: "Vamsi Krishna S ." <vamsi@in.ibm.com>
Cc: Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org, richard <richardj_moore@uk.ibm.com>,
suparna <suparna@in.ibm.com>
Subject: Re: [patch] kprobes for 2.5.73 with single-stepping out-of-line
Date: Wed, 25 Jun 2003 13:52:02 +0200 [thread overview]
Message-ID: <20030625115202.GB9645@wotan.suse.de> (raw)
In-Reply-To: <20030625161113.A20435@in.ibm.com>
On Wed, Jun 25, 2003 at 04:11:13PM +0530, Vamsi Krishna S . wrote:
> On Tue, Jun 24, 2003 at 06:01:09PM +0200, Andi Kleen wrote:
> > "Vamsi Krishna S ." <vamsi@in.ibm.com> writes:
> >
> >
> > > +static struct kprobe *current_kprobe;
> >
> > This global variable is quite unclean. It looks like it is for passing
> > function arguments around. Why is it needed?
> >
> This is used for keeping track of the probe that is currently being
> handled. This information is needed to be kept across a
> trap 3 - singlestep - trap 1. So, we set store the current probe in
> this variable while handling trap 3, for use while handling the
> subsequent trap 1.
But how can this be SMP safe? Do you hold a lock during all this?
-Andi
next prev parent reply other threads:[~2003-06-25 11:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030624140926.A17908@in.ibm.com.suse.lists.linux.kernel>
2003-06-24 16:01 ` Andi Kleen
2003-06-25 10:41 ` Vamsi Krishna S .
2003-06-25 11:52 ` Andi Kleen [this message]
2003-06-25 12:46 ` Vamsi Krishna S .
2003-06-24 8:39 Vamsi Krishna S .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030625115202.GB9645@wotan.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=richardj_moore@uk.ibm.com \
--cc=suparna@in.ibm.com \
--cc=vamsi@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®