From: Andi Kleen <ak@suse.de>
To: "Vamsi Krishna S ." <vamsi@in.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] kprobes for 2.5.73 with single-stepping out-of-line
Date: 24 Jun 2003 18:01:09 +0200 [thread overview]
Message-ID: <p73n0g74g8q.fsf@oldwotan.suse.de> (raw)
In-Reply-To: <20030624140926.A17908@in.ibm.com.suse.lists.linux.kernel>
"Vamsi Krishna S ." <vamsi@in.ibm.com> writes:
> +static struct kprobe *current_kprobe;
This global variable is quite unclean. It looks like it is for passing
function arguments around. Why is it needed?
> +#define KPROBE_HASH_BITS 6
> +#define KPROBE_TABLE_SIZE (1 << KPROBE_HASH_BITS)
> +
> +static struct list_head kprobe_table[KPROBE_TABLE_SIZE];
Use hlists?
-Andi
next parent reply other threads:[~2003-06-24 15:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030624140926.A17908@in.ibm.com.suse.lists.linux.kernel>
2003-06-24 16:01 ` Andi Kleen [this message]
2003-06-25 10:41 ` Vamsi Krishna S .
2003-06-25 11:52 ` Andi Kleen
2003-06-25 12:46 ` Vamsi Krishna S .
2003-06-24 8:39 Vamsi Krishna S .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73n0g74g8q.fsf@oldwotan.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vamsi@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®