mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oliver Neukum <oliver@neukum.org>
To: ranty@debian.org, LKML <linux-kernel@vger.kernel.org>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	orinoco-devel@lists.sf.net, jt@hpl.hp.com
Subject: Re: orinoco_usb Request For Comments
Date: Thu, 26 Jun 2003 23:41:18 +0200	[thread overview]
Message-ID: <200306262341.19110.oliver@neukum.org> (raw)
In-Reply-To: <20030626205811.GA25783@ranty.pantax.net>


>  Please comment, how much of that or what else needs to be done to get
>  it in the kernel?

	if(dev->read.urb->status == -EINPROGRESS){
		warn("%s: Unlinking pending IN urb", __FUNCTION__);
		retval = bridge_remove_in_urb(dev);
		if(retval){
			dbg("retval %d status %d", retval,
			    dev->read.urb->status);
		}
	}

Unlink unconditionally.

		/* We don't like racing :) */
		ctx->outurb->transfer_flags &= ~URB_ASYNC_UNLINK;
		usb_unlink_urb(ctx->outurb);
		del_timer_sync(&ctx->timer);

But neither do we like sleeping in interrupt. You can't simply unset the flag
if somebody else may be needing it.

More when I am rested :-)

	Regards
		Oliver


  reply	other threads:[~2003-06-26 21:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-26 20:58 Manuel Estrada Sainz
2003-06-26 21:41 ` Oliver Neukum [this message]
2003-06-26 23:09   ` Manuel Estrada Sainz
2003-06-27  8:27   ` Manuel Estrada Sainz
     [not found]     ` <Pine.LNX.4.53.0306271213350.5135@fachschaft.cup.uni-muenchen.de>
2003-07-02 10:17       ` Manuel Estrada Sainz
2003-07-02 14:02         ` Oliver Neukum
2003-06-26 22:03 ` [Orinoco-devel] " Pavel Roskin
2003-06-26 22:50   ` Manuel Estrada Sainz
2003-06-27 21:49     ` Pavel Roskin
2003-06-27 22:16       ` Manuel Estrada Sainz
2003-06-27  2:55   ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200306262341.19110.oliver@neukum.org \
    --to=oliver@neukum.org \
    --cc=jgarzik@pobox.com \
    --cc=jt@hpl.hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=orinoco-devel@lists.sf.net \
    --cc=ranty@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®