2.6.0-test3 issue

2.6.0-test3 issue

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

Hello.  I just tried to compile up 2.6.0-test3 for my x86 box, and I
noticed that the following set of options will no longer work:
CONFIG_EMBEDDED=n
CONFIG_SERIO=m
CONFIG_INPUT_KEYBOARD=y
CONFIG_KEYBOARD_ATKBD=y

The problem is that unless I set CONFIG_EMBEDDED, INPUT_KEYBOARD and
KEYBOAD_ATKBD both get set to 'Y', regardless of the other dependancies
(such as SERIO being 'm').

-- 
Tom Rini
http://gate.crashing.org/~trini/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: 2.6.0-test3 issue

[Jacek Kawa]

Tom Rini wrote:

> Hello.  I just tried to compile up 2.6.0-test3 for my x86 box, and I
> noticed that the following set of options will no longer work:
> CONFIG_EMBEDDED=n
> CONFIG_SERIO=m
> CONFIG_INPUT_KEYBOARD=y
> CONFIG_KEYBOARD_ATKBD=y
> 
> The problem is that unless I set CONFIG_EMBEDDED, INPUT_KEYBOARD and
> KEYBOAD_ATKBD both get set to 'Y', regardless of the other dependancies
> (such as SERIO being 'm').

I think it's:

...
Alan Cox:
...
  o mouse and keyboard by default if not embedded
...  

change.

(I was wandering what I had done wrong, that mousedev.ko
disappeared  8)

jk

-- 
Jacek Kawa

Re: 2.6.0-test3 issue

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

On Sun, Aug 10, 2003 at 12:33:58AM +0200, Jacek Kawa wrote:
> Tom Rini wrote:
> 
> > Hello.  I just tried to compile up 2.6.0-test3 for my x86 box, and I
> > noticed that the following set of options will no longer work:
> > CONFIG_EMBEDDED=n
> > CONFIG_SERIO=m
> > CONFIG_INPUT_KEYBOARD=y
> > CONFIG_KEYBOARD_ATKBD=y
> > 
> > The problem is that unless I set CONFIG_EMBEDDED, INPUT_KEYBOARD and
> > KEYBOAD_ATKBD both get set to 'Y', regardless of the other dependancies
> > (such as SERIO being 'm').
> 
> I think it's:
> 
> ...
> Alan Cox:
> ...
>   o mouse and keyboard by default if not embedded
> ...  
> 
> change.
> 
> (I was wandering what I had done wrong, that mousedev.ko
> disappeared  8)

Yes, but now the kernel will happily give you a non-linking kernel
because SERIO=m and ATKBD=y is 'valid'.  I don't know if this is a
Kconfig problem, ATKBD defauling to the wrong value, or both.  Or if
it's just a bad change. :)

> 
> jk
> 
> -- 
> Jacek Kawa

-- 
Tom Rini
http://gate.crashing.org/~trini/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: 2.6.0-test3 issue

[Roman Zippel]

Hi,

On Sat, 9 Aug 2003, Tom Rini wrote:

> CONFIG_EMBEDDED=n
> CONFIG_SERIO=m
> CONFIG_INPUT_KEYBOARD=y
> CONFIG_KEYBOARD_ATKBD=y
> 
> The problem is that unless I set CONFIG_EMBEDDED, INPUT_KEYBOARD and
> KEYBOAD_ATKBD both get set to 'Y', regardless of the other dependancies
> (such as SERIO being 'm').

There are multiple possibilities to fix this:

1. change the default of KEYBOARD_ATKBD to SERIO
2. force SERIO to 'y' either via 'select' or EMBEDDED
3. remove the excessive use of EMBEDDED, only INPUT needed fixing, 
everything else had reasonable defaults.

bye, Roman

Re: 2.6.0-test3 issue

[Christoph Hellwig]

On Sun, Aug 10, 2003 at 04:12:00PM +0200, Roman Zippel wrote:
> 3. remove the excessive use of EMBEDDED, only INPUT needed fixing, 
> everything else had reasonable defaults.

Patch below.  I though I sent this already but it didn't appear on
lkml yet.

--- 1.15/drivers/char/Kconfig	Wed Jul 16 13:39:32 2003
+++ edited/drivers/char/Kconfig	Sun Aug 10 11:17:02 2003
@@ -5,8 +5,8 @@
 menu "Character devices"
 
 config VT
-	bool "Virtual terminal" if EMBEDDED
-	requires INPUT=y
+	bool "Virtual terminal"
+	select INPUT
 	default y
 	---help---
 	  If you say Y here, you will get support for terminal devices with
@@ -36,7 +36,7 @@
 	  shiny Linux system :-)
 
 config VT_CONSOLE
-	bool "Support for console on virtual terminal" if EMBEDDED
+	bool "Support for console on virtual terminal"
 	depends on VT
 	default y
 	---help---
--- 1.5/drivers/input/Kconfig	Wed Jul 16 13:39:32 2003
+++ edited/drivers/input/Kconfig	Sun Aug 10 11:15:19 2003
@@ -5,7 +5,7 @@
 menu "Input device support"
 
 config INPUT
-	tristate "Input devices (needed for keyboard, mouse, ...)" if EMBEDDED
+	tristate "Input devices (needed for keyboard, mouse, ...)"
 	default y
 	---help---
 	  Say Y here if you have any input device (mouse, keyboard, tablet,
@@ -27,8 +27,8 @@
 comment "Userland interfaces"
 
 config INPUT_MOUSEDEV
-	tristate "Mouse interface" if EMBEDDED
+	tristate "Mouse interface"
 	default y
 	depends on INPUT
 	---help---
 	  Say Y here if you want your mouse to be accessible as char devices
@@ -45,8 +45,8 @@
 	  a module, say M here and read <file:Documentation/modules.txt>.
 
 config INPUT_MOUSEDEV_PSAUX
-	bool "Provide legacy /dev/psaux device" if EMBEDDED
+	bool "Provide legacy /dev/psaux device"
 	default y
 	depends on INPUT_MOUSEDEV
 
 config INPUT_MOUSEDEV_SCREEN_X
===== drivers/input/keyboard/Kconfig 1.6 vs edited =====
--- 1.6/drivers/input/keyboard/Kconfig	Wed Jul 16 13:39:32 2003
+++ edited/drivers/input/keyboard/Kconfig	Sun Aug 10 11:15:49 2003
@@ -2,7 +2,7 @@
 # Input core configuration
 #
 config INPUT_KEYBOARD
-	bool "Keyboards" if EMBEDDED || !X86
+	bool "Keyboards"
 	default y
 	depends on INPUT
 	help
@@ -12,8 +12,8 @@
 	  If unsure, say Y.
 
 config KEYBOARD_ATKBD
-	tristate "AT keyboard support" if EMBEDDED || !X86 
+	tristate "AT keyboard support"
 	default y
 	depends on INPUT && INPUT_KEYBOARD && SERIO
 	help
 	  Say Y here if you want to use a standard AT or PS/2 keyboard. Usually
===== drivers/input/serio/Kconfig 1.9 vs edited =====
--- 1.9/drivers/input/serio/Kconfig	Wed Jul 16 13:39:32 2003
+++ edited/drivers/input/serio/Kconfig	Sun Aug 10 11:16:08 2003
@@ -19,8 +19,8 @@
 	  as a module, say M here and read <file:Documentation/modules.txt>.
 
 config SERIO_I8042
-	tristate "i8042 PC Keyboard controller" if EMBEDDED || !X86
+	tristate "i8042 PC Keyboard controller"
 	default y
 	depends on SERIO
 	---help---
 	  i8042 is the chip over which the standard AT keyboard and PS/2