From: viro@parcelfarce.linux.theplanet.co.uk
To: Andries Brouwer <aebr@win.tue.nl>
Cc: Neil Brown <neilb@cse.unsw.edu.au>,
Christoph Hellwig <hch@infradead.org>,
Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2 of 2 - Allow O_EXCL on a block device to claim exclusive use.
Date: Tue, 12 Aug 2003 04:06:29 +0100 [thread overview]
Message-ID: <20030812030629.GB454@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20030812045610.B1650@pclin040.win.tue.nl>
On Tue, Aug 12, 2003 at 04:56:10AM +0200, Andries Brouwer wrote:
> On Tue, Aug 12, 2003 at 11:48:28AM +1000, Neil Brown wrote:
>
> > My first attempt at this did claim before openning.
> > However that didn't work.
> > Some aspects of the bdev that are needed for claiming are not
> > initialised before it is first opened. In particular, bd_contains,
> > gets set up by do_open.
>
> Size and structure of partitions are entirely independent of whether
> someone has opened them. Thus, the corresponding bookkeeping must
> not be in struct block_device, which exists only when the device
> is open, but in struct gendisk or so (and only there).
>
> It is a design mistake to have such stuff in struct block device.
WTF does it have to do with ->bd_contains? We *do* have the information
you (and nobody else in this thread) are talking about - in gendisk.
Exclusion upon open, OTOH, has something with opening these beast, won't
you agree?
prev parent reply other threads:[~2003-08-12 3:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-11 2:35 NeilBrown
2003-08-11 7:22 ` Christoph Hellwig
2003-08-12 1:48 ` Neil Brown
2003-08-12 2:56 ` Andries Brouwer
2003-08-12 3:06 ` viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030812030629.GB454@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=aebr@win.tue.nl \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®