mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: NeilBrown <neilb@cse.unsw.edu.au>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] 2 of 2 - Allow O_EXCL on a block device to claim exclusive use.
Date: Mon, 11 Aug 2003 12:35:57 +1000	[thread overview]
Message-ID: <E19m2XN-0002BU-00@notabene> (raw)

### Comments for ChangeSet

the blockdev layer has a concept of 'claiming' a device,
so for example it can be claimed when a filesystem is
mounted or when it is included into a raid array.
Only one subsystem can claim it at a time.

This patch matches this functionality available to user-space
via the O_EXCL flag to open.

This allows user-space programs to easily test if a device
is currently mounted etc, and to prevent a device from being
mounted or otherwise claimed.

 ----------- Diffstat output ------------
 ./fs/block_dev.c |   16 +++++++++++++++-
 1 files changed, 15 insertions(+), 1 deletion(-)

diff ./fs/block_dev.c~current~ ./fs/block_dev.c
--- ./fs/block_dev.c~current~	2003-08-11 09:01:38.000000000 +1000
+++ ./fs/block_dev.c	2003-08-11 09:01:41.000000000 +1000
@@ -643,6 +643,7 @@ int blkdev_get(struct block_device *bdev
 int blkdev_open(struct inode * inode, struct file * filp)
 {
 	struct block_device *bdev;
+	int res;
 
 	/*
 	 * Preserve backwards compatibility and allow large file access
@@ -655,7 +656,18 @@ int blkdev_open(struct inode * inode, st
 	bd_acquire(inode);
 	bdev = inode->i_bdev;
 
-	return do_open(bdev, inode, filp);
+	res = do_open(bdev, inode, filp);
+	if (res)
+		return res;
+
+	if (!(filp->f_flags & O_EXCL) )
+		return 0;
+
+	if (!(res = bd_claim(bdev, filp)))
+		return 0;
+
+	blkdev_put(bdev, BDEV_FILE);
+	return res;
 }
 
 int blkdev_put(struct block_device *bdev, int kind)
@@ -704,6 +716,8 @@ int blkdev_put(struct block_device *bdev
 
 int blkdev_close(struct inode * inode, struct file * filp)
 {
+	if (inode->i_bdev->bd_holder == filp)
+		bd_release(inode->i_bdev);
 	return blkdev_put(inode->i_bdev, BDEV_FILE);
 }
 

             reply	other threads:[~2003-08-11  2:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-11  2:35 NeilBrown [this message]
2003-08-11  7:22 ` Christoph Hellwig
2003-08-12  1:48   ` Neil Brown
2003-08-12  2:56     ` Andries Brouwer
2003-08-12  3:06       ` viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E19m2XN-0002BU-00@notabene \
    --to=neilb@cse.unsw.edu.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®