* [PATCH][v850] Guard some symbol exports with #ifdef CONFIG_MMU @ 2003-08-28 5:15 Miles Bader 2003-08-28 7:23 ` Christoph Hellwig 0 siblings, 1 reply; 3+ messages in thread From: Miles Bader @ 2003-08-28 5:15 UTC (permalink / raw) To: Linus Torvalds; +Cc: linux-kernel Linus, please apply. diff -ruN -X../cludes linux-2.6.0-test4-uc0/kernel/ksyms.c linux-2.6.0-test4-uc0-v850-20030827/kernel/ksyms.c --- linux-2.6.0-test4-uc0/kernel/ksyms.c 2003-08-25 13:23:54.000000000 +0900 +++ linux-2.6.0-test4-uc0-v850-20030827/kernel/ksyms.c 2003-08-26 11:43:52.000000000 +0900 @@ -120,7 +120,9 @@ EXPORT_SYMBOL(max_mapnr); #endif EXPORT_SYMBOL(high_memory); +#ifdef CONFIG_MMU EXPORT_SYMBOL_GPL(invalidate_mmap_range); +#endif EXPORT_SYMBOL(vmtruncate); EXPORT_SYMBOL(find_vma); EXPORT_SYMBOL(get_unmapped_area); @@ -198,7 +200,9 @@ EXPORT_SYMBOL(invalidate_inode_pages); EXPORT_SYMBOL_GPL(invalidate_inode_pages2); EXPORT_SYMBOL(truncate_inode_pages); +#ifdef CONFIG_MMU EXPORT_SYMBOL(install_page); +#endif EXPORT_SYMBOL(fsync_bdev); EXPORT_SYMBOL(permission); EXPORT_SYMBOL(vfs_permission); ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][v850] Guard some symbol exports with #ifdef CONFIG_MMU 2003-08-28 5:15 [PATCH][v850] Guard some symbol exports with #ifdef CONFIG_MMU Miles Bader @ 2003-08-28 7:23 ` Christoph Hellwig 2003-08-28 7:44 ` Miles Bader 0 siblings, 1 reply; 3+ messages in thread From: Christoph Hellwig @ 2003-08-28 7:23 UTC (permalink / raw) To: Miles Bader; +Cc: Linus Torvalds, linux-kernel On Thu, Aug 28, 2003 at 02:15:53PM +0900, Miles Bader wrote: > Linus, please apply. > > diff -ruN -X../cludes linux-2.6.0-test4-uc0/kernel/ksyms.c linux-2.6.0-test4-uc0-v850-20030827/kernel/ksyms.c > --- linux-2.6.0-test4-uc0/kernel/ksyms.c 2003-08-25 13:23:54.000000000 +0900 > +++ linux-2.6.0-test4-uc0-v850-20030827/kernel/ksyms.c 2003-08-26 11:43:52.000000000 +0900 > @@ -120,7 +120,9 @@ > EXPORT_SYMBOL(max_mapnr); > #endif > EXPORT_SYMBOL(high_memory); > +#ifdef CONFIG_MMU > EXPORT_SYMBOL_GPL(invalidate_mmap_range); > +#endif > EXPORT_SYMBOL(vmtruncate); > EXPORT_SYMBOL(find_vma); > EXPORT_SYMBOL(get_unmapped_area); > @@ -198,7 +200,9 @@ > EXPORT_SYMBOL(invalidate_inode_pages); > EXPORT_SYMBOL_GPL(invalidate_inode_pages2); > EXPORT_SYMBOL(truncate_inode_pages); > +#ifdef CONFIG_MMU > EXPORT_SYMBOL(install_page); > +#endif What about moving the exports to the definitions instead? ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][v850] Guard some symbol exports with #ifdef CONFIG_MMU 2003-08-28 7:23 ` Christoph Hellwig @ 2003-08-28 7:44 ` Miles Bader 0 siblings, 0 replies; 3+ messages in thread From: Miles Bader @ 2003-08-28 7:44 UTC (permalink / raw) To: Christoph Hellwig; +Cc: Linus Torvalds, linux-kernel Christoph Hellwig <hch@infradead.org> writes: > What about moving the exports to the definitions instead? Sounds good to me; how's this (it compiles on a no-MMU system, but ...): diff -ruN -X../cludes linux-2.6.0-test4-uc0/kernel/ksyms.c linux-2.6.0-test4-uc0-v850-20030828/kernel/ksyms.c --- linux-2.6.0-test4-uc0/kernel/ksyms.c 2003-08-25 13:23:54.000000000 +0900 +++ linux-2.6.0-test4-uc0-v850-20030828/kernel/ksyms.c 2003-08-28 16:36:28.000000000 +0900 @@ -120,7 +120,6 @@ EXPORT_SYMBOL(max_mapnr); #endif EXPORT_SYMBOL(high_memory); -EXPORT_SYMBOL_GPL(invalidate_mmap_range); EXPORT_SYMBOL(vmtruncate); EXPORT_SYMBOL(find_vma); EXPORT_SYMBOL(get_unmapped_area); @@ -198,7 +197,6 @@ EXPORT_SYMBOL(invalidate_inode_pages); EXPORT_SYMBOL_GPL(invalidate_inode_pages2); EXPORT_SYMBOL(truncate_inode_pages); -EXPORT_SYMBOL(install_page); EXPORT_SYMBOL(fsync_bdev); EXPORT_SYMBOL(permission); EXPORT_SYMBOL(vfs_permission); diff -ruN -X../cludes linux-2.6.0-test4-uc0/mm/fremap.c linux-2.6.0-test4-uc0-v850-20030828/mm/fremap.c --- linux-2.6.0-test4-uc0/mm/fremap.c 2003-05-27 11:31:39.000000000 +0900 +++ linux-2.6.0-test4-uc0-v850-20030828/mm/fremap.c 2003-08-28 16:38:39.000000000 +0900 @@ -3,7 +3,7 @@ * * Explicit pagetable population and nonlinear (random) mappings support. * - * started by Ingo Molnar, Copyright (C) 2002 + * started by Ingo Molnar, Copyright (C) 2002, 2003 */ #include <linux/mm.h> @@ -13,6 +13,8 @@ #include <linux/pagemap.h> #include <linux/swapops.h> #include <linux/rmap-locking.h> +#include <linux/module.h> + #include <asm/mmu_context.h> #include <asm/cacheflush.h> #include <asm/tlbflush.h> @@ -95,6 +97,8 @@ err: return err; } +EXPORT_SYMBOL(install_page); + /*** * sys_remap_file_pages - remap arbitrary pages of a shared backing store diff -ruN -X../cludes linux-2.6.0-test4-uc0/mm/memory.c linux-2.6.0-test4-uc0-v850-20030828/mm/memory.c --- linux-2.6.0-test4-uc0/mm/memory.c 2003-08-25 13:27:38.000000000 +0900 +++ linux-2.6.0-test4-uc0-v850-20030828/mm/memory.c 2003-08-28 16:38:53.000000000 +0900 @@ -45,6 +45,7 @@ #include <linux/pagemap.h> #include <linux/vcache.h> #include <linux/rmap-locking.h> +#include <linux/module.h> #include <asm/pgalloc.h> #include <asm/rmap.h> @@ -1138,6 +1139,7 @@ invalidate_mmap_range_list(&mapping->i_mmap_shared, hba, hlen); up(&mapping->i_shared_sem); } +EXPORT_SYMBOL_GPL(invalidate_mmap_range); /* * Handle all mappings that got truncated by a "truncate()" -Miles -- I'm beginning to think that life is just one long Yoko Ono album; no rhyme or reason, just a lot of incoherent shrieks and then it's over. --Ian Wolff ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-08-28 8:38 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2003-08-28 5:15 [PATCH][v850] Guard some symbol exports with #ifdef CONFIG_MMU Miles Bader 2003-08-28 7:23 ` Christoph Hellwig 2003-08-28 7:44 ` Miles Bader
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®