make checkconfig problem

make checkconfig problem

[Randy.Dunlap]

You probably already know this...

Someone mentioned to me that 'make checkconfig' isn't working.
However, 'make checkincludes' does work.

'checkconfig' contains the string 'config', which implies to Makefile
that this is a configs-target...

Using a target named 'checkconf' works.   Patch is below.
Or fix it however you like, of course.

--
~Randy


patch_name:	check_targets.patch
patch_version:	2003-09-04.12:31:41
author:		Randy.Dunlap <rddunlap@osdl.org>
description:	make checkconf so that it won't be a configs-target
product:	Linux
product_versions: 2.6.0-test4


diff -Naur ./Makefile~targets ./Makefile
--- ./Makefile~targets	2003-09-04 11:06:45.000000000 -0700
+++ ./Makefile	2003-09-04 12:23:55.000000000 -0700
@@ -815,7 +815,7 @@
 # Scripts to check various things for consistency
 # ---------------------------------------------------------------------------
 
-checkconfig:
+checkconf:
 	find * $(RCS_FIND_IGNORE) \
 		-name '*.[hcS]' -type f -print | sort \
 		| xargs $(PERL) -w scripts/checkconfig.pl

Re: make checkconfig problem

[Sam Ravnborg]

On Thu, Sep 04, 2003 at 12:34:52PM -0700, Randy.Dunlap wrote:
> 
> You probably already know this...
> 
> Someone mentioned to me that 'make checkconfig' isn't working.
> However, 'make checkincludes' does work.

It had crossed my mind, and my plan was actually to get rid of them
since the scripts were not updated. Good to see you are looking into
this now.

If we want to keep them in the kernel, I suggest a new naming:
configcheck:
includecheck:

This follows the *config pattern, but suffixed with check.

A tangent - could it be possible to build this into sparse instead?
The plan is to give it more kernel awareness anyway, so it should
be simple to check for the above as well.

	Sam

Re: make checkconfig problem

[Randy.Dunlap]

> On Thu, Sep 04, 2003 at 12:34:52PM -0700, Randy.Dunlap wrote:
>>
>> You probably already know this...
>>
>> Someone mentioned to me that 'make checkconfig' isn't working.
>> However, 'make checkincludes' does work.
>
> It had crossed my mind, and my plan was actually to get rid of them since
> the scripts were not updated. Good to see you are looking into this now.

They work now, and I'd like to add 'checkversion.pl' as well.

> If we want to keep them in the kernel, I suggest a new naming:
> configcheck:
> includecheck:
>
> This follows the *config pattern, but suffixed with check.

OK, I don't mind how they are spelled.

> A tangent - could it be possible to build this into sparse instead? The plan
> is to give it more kernel awareness anyway, so it should
> be simple to check for the above as well.

I don't know, but I'll discuss it with Dave Olien.

Thanks,
~Randy