mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* min_not_zero()
@ 2003-09-28  1:56 Matthew Wilcox
  0 siblings, 0 replies; only message in thread
From: Matthew Wilcox @ 2003-09-28  1:56 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel


Here's a thought ...

#define min_not_zero(l, r) \
	min((unsigned long)(l - 1), (unsigned long)(r - 1)) + 1

Seems to me that'll always give the right answer ... 0 if both 0,
otherwise the lower of the two.  And it's kind of an awkward name.
How about making it *really* specific to request_queue, putting it in
blkdev.h and calling it request_sector_min() like so:

#define request_sector_min(a, b) \
	min((a)->max_sectors - 1, (b)->max_sectors - 1) + 1

(no cast needed cos they're already unsigned.  um, unless I've misremembered
how C constants work again... should they be 1U?)

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-09-28  1:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-09-28  1:56 min_not_zero() Matthew Wilcox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®