* [PATCH 2.5] USB speedtouch: extra debug messages
@ 2003-09-29 21:39 Duncan Sands
2003-09-30 23:35 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Duncan Sands @ 2003-09-29 21:39 UTC (permalink / raw)
To: linux-usb-devel; +Cc: greg, linux-kernel
speedtch.c | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff -Nru a/drivers/usb/misc/speedtch.c b/drivers/usb/misc/speedtch.c
--- a/drivers/usb/misc/speedtch.c Tue Sep 30 00:11:41 2003
+++ b/drivers/usb/misc/speedtch.c Tue Sep 30 00:11:41 2003
@@ -880,8 +880,10 @@
return -EINVAL;
/* only support AAL5 */
- if ((vcc->qos.aal != ATM_AAL5) || (vcc->qos.rxtp.max_sdu < 0) || (vcc->qos.rxtp.max_sdu > ATM_MAX_AAL5_PDU))
+ if ((vcc->qos.aal != ATM_AAL5) || (vcc->qos.rxtp.max_sdu < 0) || (vcc->qos.rxtp.max_sdu > ATM_MAX_AAL5_PDU)) {
+ dbg ("udsl_atm_open: unsupported ATM type %d!", vcc->qos.aal);
return -EINVAL;
+ }
if (!instance->firmware_loaded) {
dbg ("udsl_atm_open: firmware not loaded!");
@@ -891,11 +893,13 @@
down (&instance->serialize); /* vs self, udsl_atm_close */
if (udsl_find_vcc (instance, vpi, vci)) {
+ dbg ("udsl_atm_open: %hd/%d already in use!", vpi, vci);
up (&instance->serialize);
return -EADDRINUSE;
}
if (!(new = kmalloc (sizeof (struct udsl_vcc_data), GFP_KERNEL))) {
+ dbg ("udsl_atm_open: no memory for vcc_data!");
up (&instance->serialize);
return -ENOMEM;
}
@@ -1220,7 +1224,7 @@
for (i = 0; i < num_rcv_urbs; i++)
if ((result = usb_unlink_urb (instance->receivers [i].urb)) < 0)
- dbg ("udsl_usb_disconnect: usb_unlink_urb on receive urb %d returned %d", i, result);
+ dbg ("udsl_usb_disconnect: usb_unlink_urb on receive urb %d returned %d!", i, result);
/* wait for completion handlers to finish */
do {
@@ -1256,7 +1260,7 @@
for (i = 0; i < num_snd_urbs; i++)
if ((result = usb_unlink_urb (instance->senders [i].urb)) < 0)
- dbg ("udsl_usb_disconnect: usb_unlink_urb on send urb %d returned %d", i, result);
+ dbg ("udsl_usb_disconnect: usb_unlink_urb on send urb %d returned %d!", i, result);
/* wait for completion handlers to finish */
do {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.5] USB speedtouch: extra debug messages
2003-09-29 21:39 [PATCH 2.5] USB speedtouch: extra debug messages Duncan Sands
@ 2003-09-30 23:35 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2003-09-30 23:35 UTC (permalink / raw)
To: Duncan Sands; +Cc: linux-usb-devel, linux-kernel
On Mon, Sep 29, 2003 at 11:39:51PM +0200, Duncan Sands wrote:
> speedtch.c | 10 +++++++---
> 1 files changed, 7 insertions(+), 3 deletions(-)
Applied, thanks.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-09-30 23:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-09-29 21:39 [PATCH 2.5] USB speedtouch: extra debug messages Duncan Sands
2003-09-30 23:35 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®