[PATCH] export [__]set_special_pids()

[PATCH] export [__]set_special_pids()

[Randy.Dunlap]

Please apply to 2.6.0-test6.

Fixes http://bugme.osdl.org/show_bug.cgi?id=1231

--
~Randy


patch_name:	set_spec_pids.patch
patch_version:	2003-10-01.21:36:33
author:		Randy.Dunlap <rddunlap@osdl.org>
description:	EXPORT [__]set_special_pids(); Ingo added these
		in include/linux/sched.h but didn't export them;
		jffs uses set_special_pids();
		(kills bug #1231)
product:	Linux
product_versions: 2.6.0-test6
diffstat:	=
 kernel/exit.c |    4 ++++
 1 files changed, 4 insertions(+)


diff -Naur ./kernel/exit.c~sspids ./kernel/exit.c
--- ./kernel/exit.c~sspids	2003-09-27 17:50:54.000000000 -0700
+++ ./kernel/exit.c	2003-10-01 21:32:45.000000000 -0700
@@ -254,6 +254,8 @@
 	}
 }
 
+EXPORT_SYMBOL(__set_special_pids);
+
 void set_special_pids(pid_t session, pid_t pgrp)
 {
 	write_lock_irq(&tasklist_lock);
@@ -261,6 +263,8 @@
 	write_unlock_irq(&tasklist_lock);
 }
 
+EXPORT_SYMBOL(set_special_pids);
+
 /*
  * Let kernel threads use this to say that they
  * allow a certain signal (since daemonize() will

Re: [PATCH] export [__]set_special_pids()

[Andrew Morton]

"Randy.Dunlap" <rddunlap@osdl.org> wrote:
>
> EXPORT [__]set_special_pids(); Ingo added these
>  		in include/linux/sched.h but didn't export them;
>  		jffs uses set_special_pids();

jffs seems to be trying to do daemonize()-by-hand.  It would be better for
it to get its act together and just call daemonize().

Is anyone actively testing and using jffs in 2.6?  How does one get it
going with blkmtd??

diff -puN fs/jffs/intrep.c~jffs-use-daemonize fs/jffs/intrep.c
--- 25/fs/jffs/intrep.c~jffs-use-daemonize	2003-10-01 22:01:21.000000000 -0700
+++ 25-akpm/fs/jffs/intrep.c	2003-10-01 22:02:26.000000000 -0700
@@ -3337,18 +3337,16 @@ jffs_garbage_collect_thread(void *ptr)
 	int result = 0;
 	D1(int i = 1);
 
+	daemonize("jffs_gcd");
+
 	c->gc_task = current;
 
 	lock_kernel();
-	exit_mm(c->gc_task);
-
-	set_special_pids(1, 1);
 	init_completion(&c->gc_thread_comp); /* barrier */ 
 	spin_lock_irq(&current->sighand->siglock);
 	siginitsetinv (&current->blocked, sigmask(SIGHUP) | sigmask(SIGKILL) | sigmask(SIGSTOP) | sigmask(SIGCONT));
 	recalc_sigpending();
 	spin_unlock_irq(&current->sighand->siglock);
-	strcpy(current->comm, "jffs_gcd");
 
 	D1(printk (KERN_NOTICE "jffs_garbage_collect_thread(): Starting infinite loop.\n"));
 

_

Re: [PATCH] export [__]set_special_pids()

[Randy.Dunlap]

On Wed, 1 Oct 2003 22:09:14 -0700 Andrew Morton <akpm@osdl.org> wrote:

| "Randy.Dunlap" <rddunlap@osdl.org> wrote:
| >
| > EXPORT [__]set_special_pids(); Ingo added these
| >  		in include/linux/sched.h but didn't export them;
| >  		jffs uses set_special_pids();
| 
| jffs seems to be trying to do daemonize()-by-hand.  It would be better for
| it to get its act together and just call daemonize().

Yes, your patch looks good to me.

| Is anyone actively testing and using jffs in 2.6?  How does one get it
| going with blkmtd??

No idea.

--
~Randy