From: "Randy.Dunlap" <rddunlap@osdl.org>
To: lkml <linux-kernel@vger.kernel.org>, torvalds <torvalds@osdl.org>
Cc: urban@teststation.com
Subject: [PATCH] smbfs/ioctl: warning: unreachable code
Date: Tue, 7 Oct 2003 13:43:05 -0700 [thread overview]
Message-ID: <20031007134305.7633bca8.rddunlap@osdl.org> (raw)
In-Reply-To: <200310070636.h976agNd019288@cherrypit.pdx.osdl.net>
On Mon, 6 Oct 2003 23:36:42 -0700 John Cherry <cherry@osdl.org> wrote:
| fs/smbfs/ioctl.c:34: warning: unreachable code at beginning of switch statement
patch_name: smbfs_ioctl.patch
patch_version: 2003-10-07.13:50:29
author: Randy.Dunlap <rddunlap@osdl.org>
description: make statements reachable
product: Linux
product_versions: 2.6.0-test6-2003.10.07
maintainer: Urban Widmark (urban@teststation.com)
diffstat: =
fs/smbfs/ioctl.c | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff -Naurp ./fs/smbfs/ioctl.c~smbioc ./fs/smbfs/ioctl.c
--- ./fs/smbfs/ioctl.c~smbioc 2003-10-07 13:12:16.000000000 -0700
+++ ./fs/smbfs/ioctl.c 2003-10-07 13:33:53.000000000 -0700
@@ -31,17 +31,20 @@ smb_ioctl(struct inode *inode, struct fi
int result = -EINVAL;
switch (cmd) {
- uid16_t uid16 = 0;
- uid_t uid32 = 0;
case SMB_IOC_GETMOUNTUID:
+ {
+ uid16_t uid16 = 0;
SET_UID(uid16, server->mnt->mounted_uid);
result = put_user(uid16, (uid16_t *) arg);
break;
+ }
case SMB_IOC_GETMOUNTUID32:
+ {
+ uid_t uid32 = 0;
SET_UID(uid32, server->mnt->mounted_uid);
result = put_user(uid32, (uid_t *) arg);
break;
-
+ }
case SMB_IOC_NEWCONN:
/* arg is smb_conn_opt, or NULL if no connection was made */
if (!arg) {
--
~Randy
prev parent reply other threads:[~2003-10-07 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-07 6:36 IA32 (2.6.0-test6 - 2003-10-06.18.30) - 2 New warnings (gcc 3.2.2) John Cherry
2003-10-07 20:43 ` Randy.Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031007134305.7633bca8.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=urban@teststation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome