IA32 (2.6.0-test6 - 2003-10-06.18.30) - 2 New warnings (gcc 3.2.2)

IA32 (2.6.0-test6 - 2003-10-06.18.30) - 2 New warnings (gcc 3.2.2)

[John Cherry]

fs/smbfs/ioctl.c:34: warning: unreachable code at beginning of switch statement
mm/memory.c:1276: warning: statement with no effect

[PATCH] smbfs/ioctl: warning: unreachable code

[Randy.Dunlap]

On Mon, 6 Oct 2003 23:36:42 -0700 John Cherry <cherry@osdl.org> wrote:

| fs/smbfs/ioctl.c:34: warning: unreachable code at beginning of switch statement



patch_name:	smbfs_ioctl.patch
patch_version:	2003-10-07.13:50:29
author:		Randy.Dunlap <rddunlap@osdl.org>
description:	make statements reachable
product:	Linux
product_versions: 2.6.0-test6-2003.10.07
maintainer:	Urban Widmark (urban@teststation.com)
diffstat:	=
 fs/smbfs/ioctl.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)


diff -Naurp ./fs/smbfs/ioctl.c~smbioc ./fs/smbfs/ioctl.c
--- ./fs/smbfs/ioctl.c~smbioc	2003-10-07 13:12:16.000000000 -0700
+++ ./fs/smbfs/ioctl.c	2003-10-07 13:33:53.000000000 -0700
@@ -31,17 +31,20 @@ smb_ioctl(struct inode *inode, struct fi
 	int result = -EINVAL;
 
 	switch (cmd) {
-		uid16_t uid16 = 0;
-		uid_t uid32 = 0;
 	case SMB_IOC_GETMOUNTUID:
+	{
+		uid16_t uid16 = 0;
 		SET_UID(uid16, server->mnt->mounted_uid);
 		result = put_user(uid16, (uid16_t *) arg);
 		break;
+	}
 	case SMB_IOC_GETMOUNTUID32:
+	{
+		uid_t uid32 = 0;
 		SET_UID(uid32, server->mnt->mounted_uid);
 		result = put_user(uid32, (uid_t *) arg);
 		break;
-
+	}
 	case SMB_IOC_NEWCONN:
 		/* arg is smb_conn_opt, or NULL if no connection was made */
 		if (!arg) {


--
~Randy