From: Andrew Morton <akpm@osdl.org>
To: Hans Reiser <reiser@namesys.com>
Cc: jw@pegasys.ws, linux-kernel@vger.kernel.org,
vs@thebsh.namesys.com, nikita@namesys.com
Subject: Re: ReiserFS patch for updating ctimes of renamed files
Date: Mon, 13 Oct 2003 03:24:31 -0700 [thread overview]
Message-ID: <20031013032431.1ed40c25.akpm@osdl.org> (raw)
In-Reply-To: <3F8A3CE0.4060705@namesys.com>
Hans Reiser <reiser@namesys.com> wrote:
>
> In theory it is cleaner and purer to do it the way we did. In practice,
> Alex's problem seems like a real one, and I don't know how hard it is to
> change tar to do the right thing. We'll discuss it in a small seminar
> today.
It would be best to make this change. minix, ext2 and ext3 do set ctime,
so it is "the Linux standard".
btw, this code:
old_dir->i_ctime = old_dir->i_mtime = CURRENT_TIME;
new_dir->i_ctime = new_dir->i_mtime = CURRENT_TIME;
old_inode->i_ctime = CURRENT_TIME;
should avoid evaluating CURRENT_TIME three times: is has some computational
cost and if an interrupt happens at the wrong time you end up with
differing times in the inode(s).
next prev parent reply other threads:[~2003-10-13 10:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-12 6:05 Alex Adriaanse
2003-10-12 7:14 ` jw schultz
2003-10-13 5:49 ` Hans Reiser
[not found] ` <20031013073154.GL8724@pegasys.ws>
2003-10-13 8:45 ` Hans Reiser
2003-10-14 2:37 ` Alex Adriaanse
2003-10-14 6:09 ` Hans Reiser
2003-10-14 6:49 ` jw schultz
2003-10-14 9:29 ` Jamie Lokier
2003-10-13 10:24 ` Andrew Morton [this message]
2003-10-14 6:13 ` Hans Reiser
2003-10-14 6:25 ` Andrew Morton
2003-10-14 6:30 ` Hans Reiser
2003-10-14 6:44 ` Andrew Morton
2003-10-14 7:09 ` jw schultz
2003-10-13 5:32 ` Hans Reiser
[not found] <Gr0H.1ol.5@gated-at.bofh.it>
2003-10-14 6:57 ` Anton Ertl
2003-10-14 8:40 ` Hans Reiser
2003-10-14 14:08 ` Alex Adriaanse
2003-10-25 14:42 ` Alex Adriaanse
[not found] <JIEIIHMANOCFHDAAHBHOMENJDAAA.alex_a@caltech.edu>
[not found] ` <3FBBA8A7.7090802@namesys.com>
[not found] ` <200311201746.15843.vs@namesys.com>
2003-11-23 4:22 ` Alex Adriaanse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031013032431.1ed40c25.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jw@pegasys.ws \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@namesys.com \
--cc=reiser@namesys.com \
--cc=vs@thebsh.namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®