From: "Alex Adriaanse" <alex_a@caltech.edu>
To: "Hans Reiser" <reiser@namesys.com>
Cc: <linux-kernel@vger.kernel.org>, "Andrew Morton" <akpm@zip.com.au>,
<vs@thebsh.namesys.com>, "jw schultz" <jw@pegasys.ws>,
"Anton Ertl" <anton@mips.complang.tuwien.ac.at>
Subject: RE: ReiserFS patch for updating ctimes of renamed files
Date: Sat, 25 Oct 2003 09:42:58 -0500 [thread overview]
Message-ID: <JIEIIHMANOCFHDAAHBHOAENFDAAA.alex_a@caltech.edu> (raw)
In-Reply-To: <3F8BB699.3070404@namesys.com>
Hi Hans,
I updated my patch to include Andrew's suggestion of eliminating extra calls
to CURRENT_TIME. I also finally got a chance to test it out, and it seems
to work. After applying this patch, ctime gets updated after a rename, and
GNU tar now backs things up properly. I also could not detect any
filesystem corruption after doing some renames.
Alex
--- fs/reiserfs/namei.c.orig Mon Aug 25 06:44:43 2003
+++ fs/reiserfs/namei.c Fri Oct 24 17:16:33 2003
@@ -1205,8 +1205,11 @@
mark_de_hidden (old_de.de_deh + old_de.de_entry_num);
journal_mark_dirty (&th, old_dir->i_sb, old_de.de_bh);
- old_dir->i_ctime = old_dir->i_mtime = CURRENT_TIME;
- new_dir->i_ctime = new_dir->i_mtime = CURRENT_TIME;
+ ctime = CURRENT_TIME;
+ old_dir->i_ctime = old_dir->i_mtime = ctime;
+ new_dir->i_ctime = new_dir->i_mtime = ctime;
+ old_inode->i_ctime = ctime;
+ reiserfs_update_sd (&th, old_inode);
if (new_dentry_inode) {
// adjust link number of the victim
@@ -1215,7 +1218,6 @@
} else {
new_dentry_inode->i_nlink--;
}
- ctime = CURRENT_TIME;
new_dentry_inode->i_ctime = ctime;
savelink = new_dentry_inode->i_nlink;
}
next prev parent reply other threads:[~2003-10-25 14:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Gr0H.1ol.5@gated-at.bofh.it>
2003-10-14 6:57 ` Anton Ertl
2003-10-14 8:40 ` Hans Reiser
2003-10-14 14:08 ` Alex Adriaanse
2003-10-25 14:42 ` Alex Adriaanse [this message]
[not found] <JIEIIHMANOCFHDAAHBHOMENJDAAA.alex_a@caltech.edu>
[not found] ` <3FBBA8A7.7090802@namesys.com>
[not found] ` <200311201746.15843.vs@namesys.com>
2003-11-23 4:22 ` Alex Adriaanse
2003-10-12 6:05 Alex Adriaanse
2003-10-12 7:14 ` jw schultz
2003-10-13 5:49 ` Hans Reiser
[not found] ` <20031013073154.GL8724@pegasys.ws>
2003-10-13 8:45 ` Hans Reiser
2003-10-14 2:37 ` Alex Adriaanse
2003-10-14 6:09 ` Hans Reiser
2003-10-14 6:49 ` jw schultz
2003-10-14 9:29 ` Jamie Lokier
2003-10-13 10:24 ` Andrew Morton
2003-10-14 6:13 ` Hans Reiser
2003-10-14 6:25 ` Andrew Morton
2003-10-14 6:30 ` Hans Reiser
2003-10-14 6:44 ` Andrew Morton
2003-10-14 7:09 ` jw schultz
2003-10-13 5:32 ` Hans Reiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=JIEIIHMANOCFHDAAHBHOAENFDAAA.alex_a@caltech.edu \
--to=alex_a@caltech.edu \
--cc=akpm@zip.com.au \
--cc=anton@mips.complang.tuwien.ac.at \
--cc=jw@pegasys.ws \
--cc=linux-kernel@vger.kernel.org \
--cc=reiser@namesys.com \
--cc=vs@thebsh.namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®