* [patch][3/3] qlogic: set host name before using scsi_host_alloc()
@ 2003-10-16 1:54 Aristeu Sergio Rozanski Filho
2003-10-17 12:03 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Aristeu Sergio Rozanski Filho @ 2003-10-16 1:54 UTC (permalink / raw)
To: linux-kernel; +Cc: Brard Roudier
[-- Attachment #1: Type: text/plain, Size: 11 bytes --]
--
aris
[-- Attachment #2: qlogic-name.patch --]
[-- Type: text/plain, Size: 846 bytes --]
--- linux/drivers/scsi/qlogicfas.c.orig 2003-10-15 23:44:55.000000000 -0200
+++ linux/drivers/scsi/qlogicfas.c 2003-10-15 23:45:36.000000000 -0200
@@ -668,6 +668,11 @@
} else
printk(KERN_INFO "Ql: Using preset IRQ %d\n", qlirq);
#endif
+ sprintf(qinfo,
+ "Qlogicfas Driver version 0.46, chip %02X at %03X, IRQ %d, TPdma:%d",
+ qltyp, qbase, qlirq, QL_TURBO_PDMA);
+ host->name = qinfo;
+
hreg = scsi_host_alloc(host, 0); /* no host data */
if (!hreg)
goto err_release_mem;
@@ -678,10 +683,6 @@
hreg->can_queue = 1;
INIT_LIST_HEAD(&hreg->sht_legacy_list);
- sprintf(qinfo,
- "Qlogicfas Driver version 0.46, chip %02X at %03X, IRQ %d, TPdma:%d",
- qltyp, qbase, qlirq, QL_TURBO_PDMA);
- host->name = qinfo;
#ifdef QL_USE_IRQ
if (qlirq < 0 || request_irq(qlirq, do_ql_ihandl, 0, "qlogicfas", hreg))
goto free_scsi_host;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch][3/3] qlogic: set host name before using scsi_host_alloc()
2003-10-16 1:54 [patch][3/3] qlogic: set host name before using scsi_host_alloc() Aristeu Sergio Rozanski Filho
@ 2003-10-17 12:03 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2003-10-17 12:03 UTC (permalink / raw)
To: Aristeu Sergio Rozanski Filho; +Cc: linux-kernel, Brard Roudier
> + sprintf(qinfo,
> + "Qlogicfas Driver version 0.46, chip %02X at %03X, IRQ %d, TPdma:%d",
> + qltyp, qbase, qlirq, QL_TURBO_PDMA);
> + host->name = qinfo;
> +
This should be
.name = "qlogicfas",
in the host template defintion instead, that makes the text const and
has no runtime overhead.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-10-17 12:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-16 1:54 [patch][3/3] qlogic: set host name before using scsi_host_alloc() Aristeu Sergio Rozanski Filho
2003-10-17 12:03 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®